From: Ferenc Wagner <wferi@niif.hu>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: CONFIG_MTD_DEBUG vs generic DEBUG support in kernel.h
Date: Thu, 18 Mar 2010 17:20:31 +0100 [thread overview]
Message-ID: <87vdctzjn4.fsf@tac.ki.iif.hu> (raw)
In-Reply-To: <1268744759.20017.58.camel@localhost> (Artem Bityutskiy's message of "Tue, 16 Mar 2010 15:05:59 +0200")
Artem Bityutskiy <dedekind1@gmail.com> writes:
> On Tue, 2010-03-16 at 13:55 +0100, Ferenc Wagner wrote:
>
>> include/linux/mtd/mtd.h contains the following snippet:
>>
>> #ifdef CONFIG_MTD_DEBUG
>> #define DEBUG(n, args...) \
>> do { \
>> if (n <= CONFIG_MTD_DEBUG_VERBOSE) \
>> printk(KERN_INFO args); \
>> } while(0)
>>
>> which conflicts with the generic debugging support in
>> include/linux/kernel.h:
>>
>> #ifdef DEBUG
>> #define pr_devel(fmt, ...) \
>> printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
>>
>> (that is, gcc emits redefinition warnings on modules which
>> #define DEBUG on their own and also include mtd.h)
>> Unfortunately, the DEBUG macro is used rather heavily under
>> drivers/mtd. Should we resolve this somehow or is it better
>> to just live with it?
>
> IMO, this MTD debug stuff is not very useful and could be just killed.
Well, I found the mtdcore debugging somewhat useful. But anyway,
killing it would be about as much work as renaming the macro, or using
something standard as dev_(v)dbg or pr_debug/devel (btw. what's the
difference?) instead. I'm willing to do some mechanical work on either
one if you wish.
--
Regards,
Feri.
next prev parent reply other threads:[~2010-03-18 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 12:55 Ferenc Wagner
2010-03-16 13:05 ` Artem Bityutskiy
2010-03-18 16:20 ` Ferenc Wagner [this message]
2010-03-19 0:36 ` Wolfram Sang
2010-04-08 8:06 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdctzjn4.fsf@tac.ki.iif.hu \
--to=wferi@niif.hu \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®