From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [Patch] Remove unnecessary check in fs/fat/inode.c
Date: Thu, 05 Oct 2006 01:36:28 +0900 [thread overview]
Message-ID: <87ven0avhv.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <1159979000.15934.7.camel@alice> (Eric Sesterhenn's message of "Wed\, 04 Oct 2006 18\:23\:20 +0200")
Eric Sesterhenn <snakebyte@gmx.de> writes:
> since all callers dereference sb, and this function
> does so earlier too, we dont need the check.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.18-git21/fs/fat/inode.c.orig 2006-10-04 18:21:03.000000000 +0200
> +++ linux-2.6.18-git21/fs/fat/inode.c 2006-10-04 18:21:22.000000000 +0200
> @@ -1472,7 +1472,7 @@ int fat_flush_inodes(struct super_block
> ret = writeback_inode(i1);
> if (!ret && i2)
> ret = writeback_inode(i2);
> - if (!ret && sb) {
> + if (!ret) {
> struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
> ret = filemap_flush(mapping);
> }
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2006-10-04 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 16:23 Eric Sesterhenn
2006-10-04 16:36 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ven0avhv.fsf@duaron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®