From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-106113.protonmail.ch (mail-106113.protonmail.ch [79.135.106.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB1BB43BDD8 for ; Wed, 12 Aug 2026 12:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.113 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786539124; cv=none; b=okDLJNfejw5OM/KpPjjSOMfmNFXOxRyqLLEy4ogPFKF+mduXlpjE8i0Q0aXRx7OTjFuBm8HWc24eidTaBbIr/H7gwkOCr3eLDSq3ZNBjFV3lUjwInJ2/eo1ijxBXYr51HM0eOWgbv5iXfOy6Myb+pjDiCOzHmmxwEZ7FI9qEWUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786539124; c=relaxed/simple; bh=GOd+T5kcO67epWictF5/E6o242qexc+4aoNyG7lkKDU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WOsf8q8f2FI1M2mu+gtUmel6wmq1uIqmwrmqtN1zDAlCypMkWEPWJ4c/yh+SnXVa8tEiYquVZVmRHABD6ZWDvLqqxGgwr6tA+JCOF7bj3ndUR9pecMwzRZTWOmmn4u5Ai5sF64wvYRoJMvKzKQzEVqT5UjxM5evLNIWLQL9Knx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com; spf=pass smtp.mailfrom=geanix.com; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b=meKc2caL; arc=none smtp.client-ip=79.135.106.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=geanix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="meKc2caL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geanix.com; s=protonmail; t=1786539111; x=1786798311; bh=kxtLFCykVROU/YI4bg47bV1oa/SHit+gxofRMN/KoBk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=meKc2caLhbR1aHbk3NF3VsqKCD37Ba+y2b0Q19TO0zLqA96N9rrsPdOpoTCZYSqNr +AIoh/dgF15czLkh95McCSzjhBLYBfSLHVpYKZUby4cB1KNdesA0yTPW/CIc/m6BZt 69X7K4J2RXf+AOHNXIYKjV42+qZStY9mZO7lHZHLUaFy6vYmGH7TaAzmyAR3uMefdf X3hOpwgltW4UhTABGmpDCsLT6ih+3KA2X9jXRg6ArlZWeEjTC219s7Z3swIZfIa6Q3 jG3YkrZBTHxO4L1h/EZAqEUYqFzm8Qa0LZlTmXWYLyaIdIusXPC+6dTXdetRLke2ul +Uavun6E+ZAFQ== X-Pm-Submission-Id: 4hKpKK0cspz1DFFG From: Esben Haabendal To: "Andy Shevchenko" Cc: "Jonathan Cameron" , "David Lechner" , Nuno =?utf-8?Q?S=C3=A1?= , "Andy Shevchenko" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Nikita Travkin" , "Maslov Dmitry" , "Kuppuswamy Sathyanarayanan" , "Thomas Gleixner" , "Pan Chuang" , "Yangtao Li" , , , Subject: Re: [PATCH v4 6/7] iio: light: ltr501: Add ltr329 driver support In-Reply-To: (Andy Shevchenko's message of "Mon, 10 Aug 2026 22:57:04 +0300") References: <20260810-liteon-ltr329-v4-0-8bd3dfd15280@geanix.com> <20260810-liteon-ltr329-v4-6-8bd3dfd15280@geanix.com> Date: Wed, 12 Aug 2026 14:51:48 +0200 Message-ID: <87wltvwlgb.fsf@geanix.com> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Andy Shevchenko" writes: > On Mon, Aug 10, 2026 at 09:11:16AM +0200, Esben Haabendal wrote: >> This adds support for the LTR-329ALS-01 chip, which is similar to >> LTR-303ALS-01, except for interrupt, which LTR-329ALS-01 chip does not >> have. > > ... > >> static int ltr501_probe(struct i2c_client *client) > >> if (client->irq > 0) { >> + if (!ltr501_has_irq_support(data->chip_info)) { >> + ret = dev_err_probe(&client->dev, -EINVAL, >> + "chip does not support irq\n"); >> + goto powerdown_on_error; >> + } > > Why making it fatal? Good point. Probably a bit too harsh. A warning should be fine. And with the addition of dt schema validation of this, on the odd chance that people validates their devicetree, they will be told about this problem already there. > Perhaps > > if (!ltr501_has_irq_support(data->chip_info) && client->irq > 0) { > client->irq = 0; > dev_warn(chip doesn't support IRQ); > } Added for v5. /Esben