From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 636393C9EE6 for ; Wed, 20 May 2026 12:17:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779279459; cv=none; b=GvXRjvxnd6WbtQD99vT1drYOBlgcdp3p84/3ItXMM6gXB4cD6F9QRaXxg7nhB1m3ZDnVpGkleOC7jpUSBDqTc2bnqK56KBew3CoTPfXd9anzM3hrXclb44JQmJwOvWikb2Y1u1ItsnyTN+fWa68GThkGttEzsJyXQl99BQNsOB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779279459; c=relaxed/simple; bh=VpI7rOOfsaUH+frlt34K5MU4Za+V4++VTqiZd3ADEZU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=O65w3pXPOJ0mJao1I+6sEXFP8YQTF7w0WlXJrdN7gh2j0JKV5H9Wx1dGrbjpyNuEHstmOZccR3b8743df3L5tiV6Mx8ySq0dkdysr6qCj9nPJJOk/nyj4KXt9WiFdFT6hMhr5eTTLxiN4RBrwAN1/kbT2xMrJ+VAACtnKfKH0V0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Vprp3n1L; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=M6Hq/4lh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Vprp3n1L"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="M6Hq/4lh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779279457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BOsyqvSnsbEyyVQ8FQKJCi5HxKx1SaIi9DZWf/ykA20=; b=Vprp3n1LLYJ2/NxbajbHih/2x/hpO3f8ImC+fnhgPH6CbhHYScJbByIqtWsvNiWDL8dfDq swxmED9Ub9KQg3Gr5gZhKbzUm53rz0CEKVojoE4IUj45qVDIuSAYxsvM+uRtKk77ztOSBb NUyX9wxFrT6X8nm0ECQYAsbPraFhFGQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-OCcKOLZkPUyub2P5-IWzXQ-1; Wed, 20 May 2026 08:17:36 -0400 X-MC-Unique: OCcKOLZkPUyub2P5-IWzXQ-1 X-Mimecast-MFC-AGG-ID: OCcKOLZkPUyub2P5-IWzXQ_1779279455 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-45e81291d62so3126864f8f.1 for ; Wed, 20 May 2026 05:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779279455; x=1779884255; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=BOsyqvSnsbEyyVQ8FQKJCi5HxKx1SaIi9DZWf/ykA20=; b=M6Hq/4lhbrX0kSPFhvuRkz0aVVnyYNaV2hX+ik4k5ZjADP9nVv0EnA3ni7UMJGI7yx bsbGsz6El4tYuNKPbVwpJq6Cy8y84vPX3+qZyfHZF7aNn0vejJ4XwzlhHaBKDPqPx4cN 7Mx3pcsLrdEZVKHOgXb+6SuLvypwFiKgdmwx0YEKJVYYF6J1bL4Tlu/qUjDe1NbL/bz2 qACGIcFfb7RDeMiIOEswJmRORYvC53rBZIYPCRzEU8CbwTfl0+9gdVklM6QFIF6gneTZ eHIxkSLvU0VjmO+liInQifRjkNdlt81ayrLOrlZyLaQ/F1jOllCjtqt3+pHK/JE+YWOF Q5xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779279455; x=1779884255; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BOsyqvSnsbEyyVQ8FQKJCi5HxKx1SaIi9DZWf/ykA20=; b=UqFlzALd/J/ohwa5tJvr9ND5N/aN/qgGraTo1Wkv03gkSUeHV05+Q9NRquKNmxkc11 2VouG4K/twVjbJr9B+KwsJXPwAitjYR/eAE4d6r7glLV7Un77EAbNJrc2jRUlcDCRikW qdoh7pV/GP/NIOAcn2nRX6YO75yQqbnXcxAuRF/91Zan+pN1UeziNOtYxKzbcr17oQUY dRi+7bWMMebQLdWpr9k3snahrEhkNDUt//MbvM9VwqXdlOcDu3I7tL2dU8jUSt379DCR xmLDQLLi8SJGomMg8X8e+T1ZGeDUxBSjku04dnQ3belmTEInj1rkBK7Lm7pOcyhk42Cs mDBw== X-Gm-Message-State: AOJu0YyCU/Ns+IwATawPXa1ILitJZS15K0YuYpg1uqPbNi0iZMHrJjaC HuAnmKzCE2n+rYX288iKPm2ZuViNFXuhtll6nProDDSLvxJIC4v7bwQtnqDkyr+w1VYFEKhGcK8 Hl7d08CdXevAqQaXQ8nfLZbdQbkWNtvzKw2SpbVQtmyI9sdI/TUl9MoGBbf7ijJ+QNQ== X-Gm-Gg: Acq92OFkOZ2fS1Ei9rin1Utha6iIn8YiwXiXbDGB7Y5NPM1ko951FD7n4GYLftGBqLu 6ayL/3B/eOxPEtO0YTNR8RrGC53LfyBTfXvLHuk1ELBbB91cjeQOvIDHyrvFbLXpIuck3TKQgCh /Kzq03NwkLkRjrJVWeJJfdlR61omHdokpxobZYDIud+6fBBV/4L4yyx463VqIJCWoLR8UTdH67Y AIg/zntf36G74+9DRy/0MbRxNjXu8lGmhcDGJuCWAonCJpfl4hItb43154E1umETy1T8PmLkBd3 8w9cKfvGeZXIAMNG0Tkbfp+3AZ1chWCFM791TOMlU07X4EFdWsjCOW16XIzB/g5yofbw4JjlSZG XQyTY+5FkZxLQGu6WfwdpnBehohq5GVWBGw62SVBYr103cLW4tjIqvhN/9AIvABI8z5kflqrRZm M22w+U X-Received: by 2002:a05:6000:22c5:b0:43d:7d24:b510 with SMTP id ffacd0b85a97d-45e5c5fd8demr39330715f8f.22.1779279454873; Wed, 20 May 2026 05:17:34 -0700 (PDT) X-Received: by 2002:a05:6000:22c5:b0:43d:7d24:b510 with SMTP id ffacd0b85a97d-45e5c5fd8demr39330657f8f.22.1779279454336; Wed, 20 May 2026 05:17:34 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45e7c22d8b7sm24543112f8f.6.2026.05.20.05.17.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 05:17:33 -0700 (PDT) From: Javier Martinez Canillas To: Dmitry Baryshkov Cc: linux-kernel@vger.kernel.org, Maxime Ripard , David Airlie , Jani Nikula , Nicolas Frattaroli , Simona Vetter , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/8] drm/display: hdmi: Add common TMDS character rate constants In-Reply-To: <62ruh7xc5bgv2iifshhnd746nfghzczblsgxrumchuak564zvt@nligwnzsw6pz> References: <20260519144712.1418302-1-javierm@redhat.com> <20260519144712.1418302-2-javierm@redhat.com> <62ruh7xc5bgv2iifshhnd746nfghzczblsgxrumchuak564zvt@nligwnzsw6pz> Date: Wed, 20 May 2026 14:17:32 +0200 Message-ID: <87wlwywa03.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Dmitry Baryshkov writes: Hello Dmitry, > On Tue, May 19, 2026 at 04:46:57PM +0200, Javier Martinez Canillas wrote: >> Several DRM drivers already define their own constants for minimum and >> maximum TMDS character rates. >> >> By defining common rate constants in a shared header, drivers can just use >> them instead of having driver local define macros or use magic numbers. >> >> The values defined in the header correspond >> to maximum TMDS character rates defined by each HDMI specification version: >> >> - DRM_HDMI_TMDS_CHAR_RATE_MIN: 25 MHz (minimum for all versions) >> - DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0: 165 MHz (HDMI 1.0 maximum) >> - DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3: 340 MHz (HDMI 1.3 maximum) >> - DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0: 600 MHz (HDMI 2.0 maximum) > > These values are also used by the HDMI PHY drivers. Would it make sense > to define them in instead? > Yes, I think you are correct. In fact I spotted more HDMI PHY drivers that could also use these defined constants but just included the most obvious ones in this patch series. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat