mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Janne Grunau <j@jannau.net>
Cc: sven@kernel.org, neal@gompa.dev, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, asahi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, j@jannau.net
Subject: Re: [PATCH 0/4] arm64: dts: apple: Add chassis-type properties
Date: Sat, 10 Jan 2026 20:26:35 +0100	[thread overview]
Message-ID: <87wm1p8e1g.fsf@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20260109-apple-dt-chassis-type-v1-0-c215503734c5@jannau.net> (message from Janne Grunau on Fri, 09 Jan 2026 16:25:42 +0100)

> From: Janne Grunau <j@jannau.net>
> Date: Fri, 09 Jan 2026 16:25:42 +0100
> 
> Add chassis-type properties for all Apple silicon Macs. "chassis-type"
> is used by u-boot to fill the SMBIOS "System Enclosure or Chassis Type"
> field. User space software uses this field to to determine if a device
> is an laptop. The exact use case eludes me unfortunately.
> 
> The Mac Pro uses "server" as chassis-type which is not entirely
> accurate. The tower and rack mount Mac Pro versions share the same .dts
> file and are identical except for the enclosure. I haven't found an
> obvious property in Apple's device tree to distinguish between those so
> both use "server" instead of the more accurate "tower" and "rack mount
> chassis". The latter chassis-types are not in dt-schema anyway.
> 
> Signed-off-by: Janne Grunau <j@jannau.net>

For the series:

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> ---
> Janne Grunau (4):
>       arm64: dts: apple: Add chassis-type property for all Macbooks
>       arm64: dts: apple: Add chassis-type property for Apple desktop devices
>       arm64: dts: apple: Add chassis-type property for Mac Pro
>       arm64: dts: apple: Add chassis-type property for Apple iMacs
> 
>  arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi | 2 ++
>  arch/arm64/boot/dts/apple/t600x-j375.dtsi      | 2 ++
>  arch/arm64/boot/dts/apple/t6022-j180d.dts      | 2 ++
>  arch/arm64/boot/dts/apple/t8103-j274.dts       | 1 +
>  arch/arm64/boot/dts/apple/t8103-j293.dts       | 1 +
>  arch/arm64/boot/dts/apple/t8103-j313.dts       | 1 +
>  arch/arm64/boot/dts/apple/t8103-j456.dts       | 1 +
>  arch/arm64/boot/dts/apple/t8103-j457.dts       | 1 +
>  arch/arm64/boot/dts/apple/t8112-j413.dts       | 1 +
>  arch/arm64/boot/dts/apple/t8112-j415.dts       | 1 +
>  arch/arm64/boot/dts/apple/t8112-j473.dts       | 1 +
>  arch/arm64/boot/dts/apple/t8112-j493.dts       | 1 +
>  12 files changed, 15 insertions(+)
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20260109-apple-dt-chassis-type-f31523a1f681
> 
> Best regards,
> -- 
> Janne Grunau <j@jannau.net>
> 
> 
> 

      parent reply	other threads:[~2026-01-10 19:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 15:25 Janne Grunau
2026-01-09 15:25 ` [PATCH 1/4] arm64: dts: apple: Add chassis-type property for all Macbooks Janne Grunau
2026-01-09 15:25 ` [PATCH 2/4] arm64: dts: apple: Add chassis-type property for Apple desktop devices Janne Grunau
2026-01-09 15:25 ` [PATCH 3/4] arm64: dts: apple: Add chassis-type property for Mac Pro Janne Grunau
2026-01-09 15:25 ` [PATCH 4/4] arm64: dts: apple: Add chassis-type property for Apple iMacs Janne Grunau
2026-01-09 15:37 ` [PATCH 0/4] arm64: dts: apple: Add chassis-type properties Neal Gompa
2026-01-10 10:39 ` Sven Peter
2026-01-10 19:26 ` Mark Kettenis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wm1p8e1g.fsf@bloch.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=asahi@lists.linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j@jannau.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neal@gompa.dev \
    --cc=robh@kernel.org \
    --cc=sven@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®