From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6E4F2E8E09 for ; Mon, 15 Dec 2025 11:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765799949; cv=none; b=gLGQVKf7jaHIT8UsVUSzKhkZ1+MB/2N/ue0UI12R2OMlndR1XB8YlKckfV5BQap2qokz2+Fx/VYJsKh5PUiUkr6OIorJKovK12ZJZ4jIduJ8+SHWUMYNYRPTt6mz3FqsQj5mVWuAjolTYG63ThEzgfSzE1cVSZx4dtGrcRlDM2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765799949; c=relaxed/simple; bh=wZdNcvxsJM85M5rNymOSLBNbQBHv/r/eI5zL+F/Jilc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=HQDxzMxWqIBATTAvk1o9Kl2Fb8LUxAbPZhirgCyv2T/ij9PGaAZPdV8hFmKwAvA8AiFUbd+49j7UqvgyTwuEMOrsg3JP/O/fJJEmFLbm6/4v3S8xTOPihNn6apYjMU0P3RmERk+XIvBHIHDaEagoWF19xNC9fRMxMYjeCHlsguc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h3wXbsHx; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=W5hpCbeL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h3wXbsHx"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="W5hpCbeL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765799946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v0bpULWF9nsWlNUyrLgROtaCnqKfxnghggyuP1lmIbw=; b=h3wXbsHxjgXmnrFKto7hvdEQKEE3JwFKbuYpqngEiLRdlVp3yRj0yDF1yOtkHmpI/dutu+ A4XnZx9ppbTnJcXlKCn8GLFN+7w2zK+c6NjC/6Qh4IRFme8YQb4ihnMNX3mw6mwSdd5ELF rBe+uiMqmM0tvwAy+7R/WK9rpRqDPwc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-qVxQIa8CPleQt8aP6NJItw-1; Mon, 15 Dec 2025 06:59:05 -0500 X-MC-Unique: qVxQIa8CPleQt8aP6NJItw-1 X-Mimecast-MFC-AGG-ID: qVxQIa8CPleQt8aP6NJItw_1765799944 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-430857e8450so1056599f8f.0 for ; Mon, 15 Dec 2025 03:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765799944; x=1766404744; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=v0bpULWF9nsWlNUyrLgROtaCnqKfxnghggyuP1lmIbw=; b=W5hpCbeLtyxxZL/D72Kz1oVeg7BV0SefQQlfdc/HyQgKbn9211TWWjn3tPjH9jPEYj tM//r4mPjFAgS41lLwCse2UyMgISL4njUrvpS86dey8diC0e30f7hVEMiLD+GiXa4wmw h84uvjz8WWbfGWdN7UWN6jytXgXzANEtYt6Olb4FAzs6FJsaJ57aWT8UAuroFKOIecuH hucIh2ETtqom46cbX29yjbIuXz1oSs5e8J3dunf3OCAzaXr3w6zJ/A0gLk/m97VgKnpQ YGISSMHCfXRQiSU8qzVEbgoC9mhu3k6Pnva2auubT1VuLu0gNXnNjaB3IGrIT/Nq6Yia fMbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765799944; x=1766404744; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v0bpULWF9nsWlNUyrLgROtaCnqKfxnghggyuP1lmIbw=; b=hZkgmTR8PzYUuVHL1vsflxi70I45VXW+GstIv5tEDCQ0lU0+MnA3B8ZVadKyIutBw5 yYkgF0jU/yug6MXppivI6eXbKS0r0oZ8AmQ/fKms+9VSBuwWPDFlbfLLdcCYpjCnQdkw egNkduEH3xL9cIzmQtc4QSII9H7S8Ie9u5dSkCj9DfUvtgUnFUj0RUjdwY25m03Ipx18 5UT/3Rli8Mc+aeovX2sMegZctF1EZ1WgssQkRUEJTwu4KG6HuJfaO2cF1hmljsD9EVwk gq4I1pNEu7/KXy0DvrvfO2SmPFQWH6DQ51JBuH68QczkqPlRAzRuGga830JdZ/3Ae5bw vIOg== X-Gm-Message-State: AOJu0Ywwgk9bnCUG0VV0LEiyb1aehvfCAs9Fiv4EN7lXEMzBsGWmm1gK RswIpMKWhd3bKgEPnl3rrRzkXG8F0aqA0Xu7iLQ6X78bVtVYr97kptQaVhIT0WeDYb5xdgM8fkY R2egfvNe9adxBqKBW3fkpsj/vuNBnkYyM+lZBuTp2u49qJHctclGVKsncA9RiHum5zBXeEaD4P6 ikFPY= X-Gm-Gg: AY/fxX5OCMjfefd03vZYPi61IbmTDJmp2g4qQv0byIFRueJEGTCIlEre4Xt1j63QDPT lNotOpGp6oMCPy7Sc1nBs7jySyw+fO/5OLpR2QQmMvEyMilz00bsmPPWSI2jOTo/nlEDxW2PrmQ TTdQZUzxDbjrsAc0RkF0Z4UD93jaY0l2adUrgrUeiN4MFZe3nxy6ycxr0adovFp2rKv0OA7lYpp vYTZGvenKhxrTAFXo78XkhieiNvBWeQ2ydoiZHIig7YGEMZqLv8TTDN1NYEBQFArI325GRG45Lk +R+eefu8+ip1rMhWHwAL36CASG02BmohcalUtouwgVnw957NI6tODt+pWnVL3B8V6KZMOp4yVNj oKynti4I+Bc3J7E1rUmDGcsTaXkurQIIq+cW7cKMmFsV+y5w5tLksQgNM75jvsGm2DVIHP2TMm8 OC0Gg= X-Received: by 2002:a5d:584e:0:b0:431:327:5dd6 with SMTP id ffacd0b85a97d-4310327603fmr11536f8f.8.1765799943695; Mon, 15 Dec 2025 03:59:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZdDwCn4R1w9yVu7KEDin2GU9QZ9kjKKddJEsFtlCvR3E+XGtjFPaq5me+k2YNFS7OQEekrQ== X-Received: by 2002:a5d:584e:0:b0:431:327:5dd6 with SMTP id ffacd0b85a97d-4310327603fmr11507f8f.8.1765799943237; Mon, 15 Dec 2025 03:59:03 -0800 (PST) Received: from localhost (red-hat-inc.vlan560.asr1.mad1.gblx.net. [159.63.51.90]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8b8a97esm34284355f8f.31.2025.12.15.03.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 03:59:02 -0800 (PST) From: Javier Martinez Canillas To: Iker Pedrosa , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 2/3] drm: Add driver for Sitronix ST7920 LCD displays In-Reply-To: <20251212-st7920-v6-2-4d3067528072@gmail.com> References: <20251212-st7920-v6-0-4d3067528072@gmail.com> <20251212-st7920-v6-2-4d3067528072@gmail.com> Date: Mon, 15 Dec 2025 12:59:01 +0100 Message-ID: <87wm2oj6re.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Iker Pedrosa writes: Hello Iker, > Add a new DRM/KMS driver for displays using the Sitronix ST7920 > controller connected via the SPI bus. This provides a standard > framebuffer interface for these common monochrome LCDs. > > Signed-off-by: Iker Pedrosa > --- [...] > diff --git a/drivers/gpu/drm/sitronix/Makefile b/drivers/gpu/drm/sitronix/Makefile > index bd139e5a6995fa026cc635b3c29782473d1efad7..2f064a518121bfee3cca73acd42589e8c54cd4d7 100644 > --- a/drivers/gpu/drm/sitronix/Makefile > +++ b/drivers/gpu/drm/sitronix/Makefile > @@ -1,3 +1,4 @@ > obj-$(CONFIG_DRM_ST7571_I2C) += st7571-i2c.o > obj-$(CONFIG_DRM_ST7586) += st7586.o > obj-$(CONFIG_DRM_ST7735R) += st7735r.o > +obj-$(CONFIG_DRM_ST7920)) += st7920.o You have two closing parenthesis here. > diff --git a/drivers/gpu/drm/sitronix/st7920.c b/drivers/gpu/drm/sitronix/st7920.c > new file mode 100644 > index 0000000000000000000000000000000000000000..c1e38beedcc660f6db96ec10cd87b2d4e62ee05e > --- /dev/null > +++ b/drivers/gpu/drm/sitronix/st7920.c > @@ -0,0 +1,868 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * DRM driver for Sitronix ST7920 LCD displays > + * > + * Copyright 2025 Iker Pedrosa > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include This header was moved to drivers/gpu/drm/clients/ by commit b86711c6d6e2 ("drm/client: Move public client header to clients/ subdirectory"). So it should be instead (and moved above the drm headers includes): #include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include You need a #include here too since you are using helpers declared in that header file. > +#include > + > +#define DRIVER_NAME "sitronix_st7920" > +#define DRIVER_DESC "DRM driver for Sitronix ST7920 LCD displays" > +#define DRIVER_DATE "20250723" This isn't used anymore, the struct drm_driver doesn't have a .date field anymore since commit cb2e1c2136f7 ("drm: remove driver date from struct drm_driver and all drivers"). There are also some checkpatch warnings, please fix those. Remember to run the checkpatch.pl script using the --strict option. Other than these small comments, the driver looks good to me. Once you fix them, feel free to add to your series: Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat