From: Takashi Iwai <tiwai@suse.de>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Don't use printk_ratelimit for debug prints
Date: Sat, 02 Aug 2025 16:19:03 +0200 [thread overview]
Message-ID: <87wm7l24dk.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250801154710.739464-1-sean.anderson@linux.dev>
On Fri, 01 Aug 2025 17:47:10 +0200,
Sean Anderson wrote:
>
> printk_ratelimit is deprecated, since it shares state with all other
> printk sites. Additionally, the suppression message is printed at
> warning level even though the actual messages are printed at debug and
> are (usually) invisible! This can result in thousands of messages like
>
> retire_capture_urb: 4992 callbacks suppressed
>
> in the console, and can inhibit debugging since it is unclear what the
> source of the suppressed callbacks is.
>
> Switch to dev_dbg_ratelimited which doesn't print anything unless debug
> is enabled.
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-08-02 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 15:47 Sean Anderson
2025-08-02 14:19 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wm7l24dk.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sean.anderson@linux.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®