From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18B251DB145 for ; Wed, 15 Jan 2025 11:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736939195; cv=none; b=M+Ro1Y1Zkk9zLoiio7IpNMa9nYJVlIKmyO8nzGwcsx62nozTuZNtZNHNmUTmlGDgXkR9a/NFdOqsGx9G4sW4XTYnqoPiZxmcqYck8+0Aw6O8IV+XVqsmuV+z9rOKdJussBQ1FybhBui+KcPTrmdBDU1/RH+FZdzSgLWJYZ+SZVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736939195; c=relaxed/simple; bh=w9mwinrL6hBiYzn7Vrpe/sNRHVv7w009sCzOvv5Id1c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Oa59nqUloeiGCy3tonovX+/AQLZdoaocZ0Ull/uMn1m0GYV8zvRluKmqjDtrCOckXjfwwPtvr1QVoEycqMQwj75ZNF0dwxHbGuTH6TtkU7xk2odmRfkBJ6CAagK6omi9RKOyb74XnevIsvZzF15XG9dEkprzvSlAJ2k52vHDPjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=SP3EhNeb; arc=none smtp.client-ip=115.124.30.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="SP3EhNeb" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1736939188; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=y/9N7h8M4mnGUGdigZku9n2F1QzzwFqLSDvUXJGm+wU=; b=SP3EhNebE09/JBzbAMAhxbFSMuyOe+k2p5Ho1NfJ0U93B4NnDBbcKDTmPz1KQz3o06sQ3EJk1Sr0NLF+MwHQIhgDpuD01UM+97nbzCBjHfL7Z+xuqueNLyGQzuTaZ3CZY/21UIzqmrpbkrM6xE628jOaxMGEemLS241Dus05hHg= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0WNiMT7w_1736939182 cluster:ay36) by smtp.aliyun-inc.com; Wed, 15 Jan 2025 19:06:28 +0800 From: "Huang, Ying" To: Nikhil Dhama Cc: , , , , , , , , Subject: Re: [FIX PATCH] mm: pcp: fix pcp->free_count reduction on page allocation In-Reply-To: <20250109114230.24203-1-nikhil.dhama@amd.com> (Nikhil Dhama's message of "Thu, 9 Jan 2025 17:12:29 +0530") References: <20250107210506.3336da0da4332002847c89a3@linux-foundation.org> <20250109114230.24203-1-nikhil.dhama@amd.com> Date: Wed, 15 Jan 2025 19:06:21 +0800 Message-ID: <87wmew72vm.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Nikhil Dhama writes: >> The present division by two appears to be somewhat randomly chosen. >> And as far as I can tell, this patch proposes replacing that with >> another somewhat random adjustment. >> >> What's the actual design here? What are we attempting to do and why, >> and why is the proposed design superior to the present one? > > We are further analyzing both the designs and their impact on pcp list. > > >> Nice, but might other workloads on other machines get slower? > > We are studying the impact of this on other network workloads like netperf, > and will post those results soon. To tune this parameter, in addition to network workloads, other kinds of workloads need be evaluated too. --- Best Regards, Huang, Ying