From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8E1F1F9F58 for ; Wed, 8 Jan 2025 12:32:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736339573; cv=none; b=CDHCwNYt0UvOrxQm7xNXP7xD95vjoA+jSu4Xy3pe5xI/aKA2AOHezTOxF5D0ANDx7oC4NiKN3+E1EZKyIQ9g3Ujie5nF//GcfimVD6+XHakoRL2RbLJ8IOmPq9lXEu4yODO/H8GsdJ5xkbAPqDphVBMiRHvP48JO6PhpHM9GZjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736339573; c=relaxed/simple; bh=lkjyl+rs6b2R9eiItQ8YmtxqyyDj/3JLG0dwaGNP0fM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=IEdj35KFxUhg+AkVOvmDB6U/Oj7HnoAxE+va6kWljzlbXKNFjRclbf53bAFS1xSpVMqSLDqcUMv4wmY/K6AFf8mhMTLme57v5jUV8diAEKuxDp2NtKsnNdzC9f9IKiWCsmUeGI+5/nqwib9XjrbBaDAWXiMr6x66+min+6msff8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bLzQFqEx; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bLzQFqEx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736339570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k1UEPDcsnN4NWhYwC/sb2nmfU8hOvBlPL6EYS1RqShk=; b=bLzQFqExXWzk83DlhRDzssFV+wABWu9V3SV+1BV7oMn4cmBWytqZe8wA494imZaWY8Db69 AwPsTE+ixDJl6DciSgykovNHY54LSd7BesJg0hy0MZwuuHStxwAYwh0zmN7wywjmuMB7dZ XA1bc7ApoFERhuSnZozkwa60ZGB5yfo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-tAPL30d_NniT3u0L-hp1yg-1; Wed, 08 Jan 2025 07:32:49 -0500 X-MC-Unique: tAPL30d_NniT3u0L-hp1yg-1 X-Mimecast-MFC-AGG-ID: tAPL30d_NniT3u0L-hp1yg Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385e00ebb16so4350835f8f.3 for ; Wed, 08 Jan 2025 04:32:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736339568; x=1736944368; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k1UEPDcsnN4NWhYwC/sb2nmfU8hOvBlPL6EYS1RqShk=; b=ZCd/EzCTpq11rkwBNFX9SWIA3RPV4jGNTLoBqc27Za1QFtm3eMS/9mfH2iMgoHRnUr V0Sk3OkHpmaTuaJSaG7g7GwUczQyS1mCGf8z+Sb0k1hff1U4M1tVZgOyCbu3QXTHMI2w Min+6reOPkzN2Cxfn8DNOlslWXKv40aYvfDvUNdTxv4F2JXcC6Mft7MRmB3Hr0hTaEul EMP+Qxs6JkX8mjonlfWXrDFiSmQu3tnYnNap3/PSw6G8+R6y7fz8Mvo9ZJLWr7jiBOa4 ldiIdn3e18Aq6N+0cT9OSH3tnJdh+uOJNDbRP1MQjWpfZiSAueK701/BsNmWpuJlnJXV XrAw== X-Gm-Message-State: AOJu0YzbfxUM+pu3WPro+3UVNO8tCbUFHWY5Gzwu/E/rRjowAEtwk2+0 OhFA4ZwIy/W5H90/Vs9TyUGuGZIhgT+YtHtepk7gIjUvpthQFB6kpuIw2daaUGYvHKD2lrO3GRv i/FHtolmU/PqQZ6cUcW4LBPFtY6zbXr4bff4q8NuiYAY9R/3DjANyHLK+GgWUkw== X-Gm-Gg: ASbGncuTjMIGmpMD8TWQa2dbTuN68v9fiqObMhv6AVNu/0VPIKBGc1+8j1dTdtaBC0F 2HYV7zJ0Y+ql1owvpoBgTDE5V5a+JcjNYfGDtCOdetUK9xZ7VfSW0T7NIc9L8uu7kr5juHxvmxU q/Bcaw3OEHrvtA8D8G3dcjPpnfSwQaom/r5pw+SWyWSh4gOaLCEYPR2qFQ/DW6Aw9wuo/YW5hNB 60eQM42MGguMQ7MUj4j6wF+gOl7uTfYEFowUye+TVfZCwMeXqbbknrCmjKJ7QA08cOjspoIM5v/ u0pZOPEtHSuNc87iY5TjE22/2hu+ugHF0cUt/08= X-Received: by 2002:a05:6000:401e:b0:386:366d:5d03 with SMTP id ffacd0b85a97d-38a872da868mr2167431f8f.16.1736339568408; Wed, 08 Jan 2025 04:32:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3m1fLbO7hQhrw5TYsrYCXVEskXDvHw1Rd6gLmWrZvoyyPUUNzgMR6flo65Nq/VSQH5WP8Ag== X-Received: by 2002:a05:6000:401e:b0:386:366d:5d03 with SMTP id ffacd0b85a97d-38a872da868mr2167403f8f.16.1736339567996; Wed, 08 Jan 2025 04:32:47 -0800 (PST) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a28f17315sm47342858f8f.108.2025.01.08.04.32.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 04:32:47 -0800 (PST) From: Javier Martinez Canillas To: Dmitry Baryshkov Cc: linux-kernel@vger.kernel.org, Mark Brown , David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/ssd130x: Set SPI .id_table to prevent an SPI core warning In-Reply-To: <874j2jkcnt.fsf@minerva.mail-host-address-is-not-set> References: <20241231114516.2063201-1-javierm@redhat.com> <877c7fkgs5.fsf@minerva.mail-host-address-is-not-set> <874j2jkcnt.fsf@minerva.mail-host-address-is-not-set> Date: Wed, 08 Jan 2025 13:32:46 +0100 Message-ID: <87wmf5iiz5.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Javier Martinez Canillas writes: > Dmitry Baryshkov writes: > >> On Tue, Dec 31, 2024 at 04:34:34PM +0100, Javier Martinez Canillas wrote: >>> Dmitry Baryshkov writes: >>> >>> Hello Dmitry, >>> >>> > On Tue, Dec 31, 2024 at 12:44:58PM +0100, Javier Martinez Canillas wrote: >> >> [...] >> >>> >> Since the check is done even for built-in drivers, drop the condition to >>> >> only define the ID table when the driver is built as a module. Finally, >>> >> rename the variable to use the "_spi_id" convention used for ID tables. >>> >> >>> >> Signed-off-by: Javier Martinez Canillas >>> > >>> > Fixes: 74373977d2ca ("drm/solomon: Add SSD130x OLED displays SPI support") >>> > >>> >>> I was on the fence about adding a Fixes: tag due a) the issue being there >>> from the beginning as you pointed out and b) the warning being harmless. >>> >>> But I'll add it to v2 or just before pushing it to drm-misc-next. >> >> Just before pushing is enough. dim b4-shazam can do that for you. >> > > Yeah, I meant in case that I post a v2. I'll wait a few days before > pushing in case someone else chimes in. Thanks again! > Pushed to drm-misc (drm-misc-next). Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat