From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79EE9EB64DC for ; Sat, 1 Jul 2023 07:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbjGAHSi (ORCPT ); Sat, 1 Jul 2023 03:18:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjGAHSd (ORCPT ); Sat, 1 Jul 2023 03:18:33 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECF85E46 for ; Sat, 1 Jul 2023 00:18:28 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BB6EC1F8A3; Sat, 1 Jul 2023 07:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688195906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dnNfQWAVOrywAuMeEMn4jzfh53L5Vun5bOiBEQTwrO8=; b=im3P+4YteuJTJ6i95M5T1lOesMB5D6s3Nqk591CQ8yaf3GuWVe2/E3VshPBuO0Vy4NEfK9 nrrEKZNfsZECeTonuu49yuIg5N27tGxNIRcy+89SyE6OlZUUeHVu55Fsm9xqhCoqfMNs/7 UCdbIw63ogSOLVqJWcf2VJW9DLr9o0M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688195906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dnNfQWAVOrywAuMeEMn4jzfh53L5Vun5bOiBEQTwrO8=; b=t8E7qYJ18fwttntVBryL40WRCM+1ebt7fJIE3lvgh3gJM5ElmbVasjMWgKWLIf9Umxl/AH rsYQc1nWzXeXGPBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8E03A13638; Sat, 1 Jul 2023 07:18:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9fO5IULTn2REcwAAMHmgww (envelope-from ); Sat, 01 Jul 2023 07:18:26 +0000 Date: Sat, 01 Jul 2023 09:18:25 +0200 Message-ID: <87wmzk6qwu.wl-tiwai@suse.de> From: Takashi Iwai To: dengxiang Cc: tiwai@suse.com, yangyingliang@huawei.com, perex@perex.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760 In-Reply-To: <20230701063051.2543538-1-dengxiang@nfschina.com> References: <20230701063051.2543538-1-dengxiang@nfschina.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 01 Jul 2023 08:30:51 +0200, dengxiang wrote: > > These models use NSIWAY amplifiers for internal speaker, but cannot put > sound outside from these amplifiers. So eapd verbs are needed to initialize > the amplifiers. They can be added during boot to get working sound out > of internal speaker. > > --- > V3: > - do some adjustment for eapd verbs and keep the capital letters for > ALC_* enums. > v2: > - remove warning about unused variable 'spec'. Looks almost good, but I forgot one more thing: > @@ -11792,6 +11800,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { > SND_PCI_QUIRK(0x1b35, 0x1234, "CZC ET26", ALC662_FIXUP_CZC_ET26), > SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T), > SND_PCI_QUIRK(0x1c6c, 0x1239, "Compaq N14JP6-V2", ALC897_FIXUP_HP_HSMIC_VERB), > + SND_PCI_QUIRK(0x10ec, 0x0897, "UNIS H3C X500s", ALC897_FIXUP_UNIS_H3C_X500S), > > #if 0 > /* Below is a quirk table taken from the old code. The table is sorted in SSID order, so please put at the right position. thanks, Takashi