From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12768C433FE for ; Fri, 21 Oct 2022 14:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbiJUOvG (ORCPT ); Fri, 21 Oct 2022 10:51:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230052AbiJUOu4 (ORCPT ); Fri, 21 Oct 2022 10:50:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70DC1237FB3 for ; Fri, 21 Oct 2022 07:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666363854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3KqX3cQJyXO8DgUbmcCGSuro7kDodg56LrRmLb6OdXw=; b=U9RemClIwLARdPL9RzHZc/nj8BpFxP4L3MElp6L5MRfcLZ/43i1O/Cwc3qM2G0xYmNXxwg 5ZP3vuaUjSudXGymUDGh2mFnLAnPYr08UOIN6Hq6iiYzdaFMr1o1BVApnYru4N9DPh6C1V wP5uwPMTkKfRPOeinwROXN/uZwZiL/k= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-562-FqoZQfudN9Oui1mxLzQKzw-1; Fri, 21 Oct 2022 10:50:52 -0400 X-MC-Unique: FqoZQfudN9Oui1mxLzQKzw-1 Received: by mail-ed1-f72.google.com with SMTP id z11-20020a056402274b00b0045ca9510fc8so2766218edd.23 for ; Fri, 21 Oct 2022 07:50:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3KqX3cQJyXO8DgUbmcCGSuro7kDodg56LrRmLb6OdXw=; b=DaPqvj1lGU+yMfE/QgYiT6DUUkISFNCvhZpDAX7OlonFifhHzJUZ+fVYpbT2Jqu7sm F1tmFy0Zq6MoJwzTLrWlY6bSyOj0acADx2UPwttqqEFx70bKD9wQ8e1S+9059Q0b6hJu 6Lj7rIrweyCdJy3OSqgVYqwQkYV5ZclVXpQ00Ze27u1TIA4Pcz7at7Hyv+gTWLFYQyTL 6C68H+5f5cdCQ5agR0S6Ni4+84YbBW4AZXxZI3JtGJTB0sUDV7oOxtUrAE7t1XuD9UMP c270hEHDM3TWqHr12VjBTbz+0XORQa0aIzoci6gZedbIZKPozHP259jsWkLf3esMuYD/ M7iQ== X-Gm-Message-State: ACrzQf2773smUZVEBDVPfQwsEAtpFKqHUJmALfkVwf6Z/QWgKA4zgyQZ QuIHI1bRAUVcsDBypoZjhzWxoKYTB4tvR41zyX0yVlJat7R2Gfa+UtFPmWUCKf0MnAShZId2pqR tW10Y3aGjye711QBjMeN97XJmjDhydiePp3qRUSELzI/tbNrPM2oEP1WdcgdRYbXAqHzKsVJ6s8 wT X-Received: by 2002:a05:6402:2b8d:b0:43a:5410:a9fc with SMTP id fj13-20020a0564022b8d00b0043a5410a9fcmr18067379edb.99.1666363851639; Fri, 21 Oct 2022 07:50:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5J8Tepa5KCpS+HvcbR1Fjb2ekWhuUACSZhePPlBCOVX120kQfGnZ0JJY3aPy+j1VOKboUWWQ== X-Received: by 2002:a05:6402:2b8d:b0:43a:5410:a9fc with SMTP id fj13-20020a0564022b8d00b0043a5410a9fcmr18067350edb.99.1666363851353; Fri, 21 Oct 2022 07:50:51 -0700 (PDT) Received: from ovpn-192-65.brq.redhat.com (nat-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id ku16-20020a170907789000b0078ca30ee18bsm11857943ejc.95.2022.10.21.07.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 07:50:50 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Michael Kelley , Siddharth Chandrasekaran , Yuan Yao , Maxim Levitsky , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 44/46] KVM: selftests: evmcs_test: Introduce L2 TLB flush test In-Reply-To: References: <20221004123956.188909-1-vkuznets@redhat.com> <20221004123956.188909-45-vkuznets@redhat.com> Date: Fri, 21 Oct 2022 16:50:49 +0200 Message-ID: <87wn8tb586.fsf@ovpn-192-65.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sean Christopherson writes: > On Tue, Oct 04, 2022, Vitaly Kuznetsov wrote: ... >> >> + /* L2 TLB flush setup */ >> + current_evmcs->partition_assist_page = hv_pages->partition_assist_gpa; >> + current_evmcs->hv_enlightenments_control.nested_flush_hypercall = 1; >> + current_evmcs->hv_vm_id = 1; >> + current_evmcs->hv_vp_id = 1; >> + current_vp_assist->nested_control.features.directhypercall = 1; >> + *(u32 *)(hv_pages->partition_assist) = 0; >> + >> GUEST_ASSERT(!vmlaunch()); > > Pre-existing code, but would it make sense to add an assert here to verify L2 > exited due to an NMI? Feel free to ignore this for now if it's not straightforward, > this series is plenty big :-) > Well, simple + GUEST_ASSERT_EQ(vmreadz(VM_EXIT_REASON), EXIT_REASON_EXCEPTION_NMI); + GUEST_ASSERT_EQ((vmreadz(VM_EXIT_INTR_INFO) & 0xff), NMI_VECTOR); seems to be working (passing) so why not :-) -- Vitaly