From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C8EC43334 for ; Thu, 14 Jul 2022 08:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237121AbiGNItn (ORCPT ); Thu, 14 Jul 2022 04:49:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbiGNItm (ORCPT ); Thu, 14 Jul 2022 04:49:42 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D21D3ED40 for ; Thu, 14 Jul 2022 01:49:40 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 384E334B0D; Thu, 14 Jul 2022 08:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657788579; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oShnEqtXBukDXQF3z10I1RLGnsnZQA+o7J3vqVFCe2c=; b=EJ76AQG85XCgCUMMiO6gw21bMC6QDhvbeJcQ5balxzTZAUVDrRhpRYLzqCDxqOPhlaA9MB 9MyFRYFs/roPoyDye+6g4kjK4v+mjbn+hFgdvFXUK7atjk1RWIQnwrIrh8YvH+VFiKw/6C JLTs0zTIdRHM5iMQsFuwBUB3U1+weVo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657788579; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oShnEqtXBukDXQF3z10I1RLGnsnZQA+o7J3vqVFCe2c=; b=Xa7tlOL7X89PRP8oZzrlA0uXLH0bJqwBvpwlmoZPV7no9qW+WehYXIvlfD9m6RTlQadDRJ f6uT62ar8uAG8XBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1E22D13A61; Thu, 14 Jul 2022 08:49:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6SG2BqPYz2I4GQAAMHmgww (envelope-from ); Thu, 14 Jul 2022 08:49:39 +0000 Date: Thu, 14 Jul 2022 10:49:38 +0200 Message-ID: <87wncgw02l.wl-tiwai@suse.de> From: Takashi Iwai To: Uros Bizjak Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Use atomic_try_cmpxchg in ep_state_update In-Reply-To: <20220713151946.4743-1-ubizjak@gmail.com> References: <20220713151946.4743-1-ubizjak@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jul 2022 17:19:46 +0200, Uros Bizjak wrote: > > Use atomic_try_cmpxchg instead of atomic_cmpxchg (*ptr, old, new) == old in > ep_state_update. x86 CMPXCHG instruction returns success in ZF flag, > so this change saves a compare after cmpxchg (and related move instruction > in front of cmpxchg). > > No functional change intended. > > Signed-off-by: Uros Bizjak > Cc: Takashi Iwai Thanks, applied. Takashi