From: Michael Ellerman <mpe@ellerman.id.au>
To: Christoph Hellwig <hch@lst.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Christoph Hellwig <hch@lst.de>,
Alistair Popple <alistair@popple.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/npu-dma: Remove NPU DMA ops
Date: Wed, 31 Oct 2018 02:01:53 +1100 [thread overview]
Message-ID: <87wopziila.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181030132401.GC30783@lst.de>
Christoph Hellwig <hch@lst.de> writes:
> On Wed, Oct 31, 2018 at 12:09:29AM +1100, Benjamin Herrenschmidt wrote:
>> On Tue, 2018-10-30 at 13:58 +0100, Christoph Hellwig wrote:
>> > Please take my patch instead. We have a kernel polcity to not keep
>> > dead code around, and everyone including Linus and the attending IBMers
>> > confirmed this.
>>
>> Let's call a cat a cat ... ;-)
>>
>> It's not *dead* code. It's code that is used by an out of tree driver
>> (which also happen not to be open source).
(Actually that part of the driver is MIT licensed, but yes other parts
are not open source.)
> Which clearly makes it a derived work of the kernel if it uses an
> interface just create for it, and thus even more important to remove
> it to not get anyone into legal trouble.
We don't want driver code calling into firmware, that's the job of
platform code, so we would need the same API (or something similar) for
a GPL driver.
cheers
next prev parent reply other threads:[~2018-10-30 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 11:02 Alistair Popple
2018-10-30 12:58 ` Christoph Hellwig
2018-10-30 13:09 ` Benjamin Herrenschmidt
2018-10-30 13:24 ` Christoph Hellwig
2018-10-30 15:01 ` Michael Ellerman [this message]
2018-11-07 21:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wopziila.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=alistair@popple.id.au \
--cc=benh@kernel.crashing.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®