From: Michael Ellerman <mpe@ellerman.id.au>
To: Joe Perches <joe@perches.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Andy Whitcroft <apw@canonical.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: Checkpatch bad Warning (Re: [PATCH] powerpc/kgdb: add kgdb_arch_set/remove_breakpoint())
Date: Thu, 20 Sep 2018 23:13:43 +1000 [thread overview]
Message-ID: <87worgia60.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <595c96f5adcccd7eab9dc95eb48618981af66d3c.camel@perches.com>
Joe Perches <joe@perches.com> writes:
> On Tue, 2018-09-18 at 09:33 +0000, Christophe Leroy wrote:
>> On the below patch, checkpatch reports
>>
>> WARNING: struct kgdb_arch should normally be const
>> #127: FILE: arch/powerpc/kernel/kgdb.c:480:
>> +struct kgdb_arch arch_kgdb_ops;
>>
>> But when I add 'const', I get compilation failure
>
> So don't add const.
>
> checkpatch is stupid. You are not.
>
> _Always_ take checkpatch bleats with very
> large grains of salt.
>
> Perhaps send a patch to remove kgbd_arch
> from scripts/const_structs.checkpatch as
> it seems not ever to be const.
I think it could/should be const though, it just requires updating all
arches.
cheers
next prev parent reply other threads:[~2018-09-20 13:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 9:26 [PATCH] powerpc/kgdb: add kgdb_arch_set/remove_breakpoint() Christophe Leroy
2018-09-18 9:33 ` Checkpatch bad Warning (Re: [PATCH] powerpc/kgdb: add kgdb_arch_set/remove_breakpoint()) Christophe Leroy
2018-09-20 3:02 ` Joe Perches
2018-09-20 13:13 ` Michael Ellerman [this message]
2018-09-20 13:19 ` Christophe LEROY
2018-09-20 1:23 ` Christophe Leroy
2018-09-20 20:36 ` Paul Burton
2018-09-20 14:07 ` Christophe Leroy
2018-10-22 9:37 ` powerpc/kgdb: add kgdb_arch_set/remove_breakpoint() Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87worgia60.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=apw@canonical.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome