From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754178AbdJLVkb (ORCPT ); Thu, 12 Oct 2017 17:40:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:54543 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbdJLVka (ORCPT ); Thu, 12 Oct 2017 17:40:30 -0400 From: NeilBrown To: Josh Poimboeuf Date: Fri, 13 Oct 2017 08:40:20 +1100 Cc: Linus Torvalds , Ingo Molnar , LKML Subject: Re: [PATCH] scripts: fix faddr2line to work on last symbol In-Reply-To: <20171012155555.jdryge43krhsjw64@treble> References: <8760blnj8j.fsf@notabene.neil.brown.name> <20171012155555.jdryge43krhsjw64@treble> Message-ID: <87wp40m4e3.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, Oct 12 2017, Josh Poimboeuf wrote: > On Thu, Oct 12, 2017 at 02:22:04PM +1100, NeilBrown wrote: >>=20 >> If faddr2line is given a function name which is the >> last one listed by "nm -n", it will fail because it >> never finds the next symbol. >>=20 >> So teach the awk script to catch that possibility, >> and use 'size' to provide the end point of the last >> function. >>=20 >> Signed-off-by: NeilBrown > > Thanks. I'm assuming you saw this issue with a .o file, and not with > vmlinux? Because on my vmlinux, the last symbol isn't a text symbol. Yes, I was using a .o Thanks for looking further into this - there certainly are subtleties that I missed. Thanks, NeilBrown --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlnf4UUACgkQOeye3VZi gbnr6Q//an0CxUsS1zeXE3v4+KlV7pC/G62YnacsRp+8wtiUEgs2dNPpvPlxMOuc WUMaEuGqXVhojLNbxxiW7lPkNGaaJSc3p0dX5EPcwxYRvXf2IqCN1iWrL64aGfXj z2ifOWhEl3R7Y0stef/c+/GNYChd3EyBnA7eOKQdYKCw/ObZn/QcF57V2Xd7F3YH IR37QO3EzbDonSV284nwNC7p0aipzUdI3eN4voZ0LYnOBG0iVI4EPpW0Rt0AP0Iu MvYYpb4pGwf0lNZUv/+9hVNBl+R194h0Hnrd4wIcFmW04CCxi8ync9Eawn/0A/25 eWnnBHwW966PamOTW6EReX3IQzN+2DcPDVa7dwpLi/5roK5tm2OdcFWKRfMhMF+N ddTsdgEdoDgcEovFW2r9xqvMkNvjF5kU23MdKQB+g+P4IaR4csQgZO8lMZG+i6YT UnBcyOBXXrCMJW4HEUNfZMc5RAIBJrT2Lbun3NjlXnErHh2koIOoyee8b2P+rYfD oI2hIyHzu3n25pYUxwomac3ti39mm4RQ2upVCJXjm0+jqQf/qX34t63ZrDZ0Iswp HKnDB0MF/laFDRPlhGCt+F+DIl4ku9Huc15ekPMbrOWvSD0iif2g2G65SHNTIp9W ww0VhnmpPkCn9J3gIW3XN0J/uT9yYaB34X/09ZUJgTGD0MulRFA= =/vtA -----END PGP SIGNATURE----- --=-=-=--