mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Cc: benh@kernel.crashing.org, paulus@samba.org,
	maddy@linux.vnet.ibm.com, tglx@linutronix.de, mingo@kernel.org,
	kan.liang@intel.com, linux-kernel@vger.kernel.org,
	Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc/sysrq: Fix oops whem ppmu is not registered
Date: Tue, 19 Sep 2017 20:00:49 +1000	[thread overview]
Message-ID: <87wp4vknxq.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1505801826-12396-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com>

Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> writes:

> Kernel crashes if power pmu is not registered and user tries to dump
> regs with 'echo p > /proc/sysrq-trigger'. Sample log:
>
>   Unable to handle kernel paging request for data at address 0x00000008
>   Faulting instruction address: 0xc0000000000d52f0
>
>   NIP [c0000000000d52f0] perf_event_print_debug+0x10/0x230
>   LR [c00000000058a938] sysrq_handle_showregs+0x38/0x50
>   Call Trace:
>    printk+0x38/0x4c (unreliable)
>    __handle_sysrq+0xe4/0x270
>    write_sysrq_trigger+0x64/0x80
>    proc_reg_write+0x80/0xd0
>    __vfs_write+0x40/0x200
>    vfs_write+0xc8/0x240
>    SyS_write+0x60/0x110
>    system_call+0x58/0x6c

Thanks.

I added:

  Fixes: 5f6d0380c640 ("powerpc/perf: Define perf_event_print_debug() to print PMU register values")

But I don't think I'll Cc stable, I can't think why we'd ever *not* have
a ppmu registered. How did you hit it?

cheers

  reply	other threads:[~2017-09-19 10:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19  6:17 Ravi Bangoria
2017-09-19 10:00 ` Michael Ellerman [this message]
2017-09-19 10:04   ` Madhavan Srinivasan
2017-09-21  1:46 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp4vknxq.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.vnet.ibm.com \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=ravi.bangoria@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®