From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbcHIK7z (ORCPT ); Tue, 9 Aug 2016 06:59:55 -0400 Received: from ozlabs.org ([103.22.144.67]:56056 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565AbcHIK7y (ORCPT ); Tue, 9 Aug 2016 06:59:54 -0400 From: Michael Ellerman To: Mimi Zohar , linux-security-module@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Thiago Jung Bauermann , linux-ima-devel@lists.sourceforge.net, Mimi Zohar , Dave Young Subject: Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list In-Reply-To: <1470313475-20090-2-git-send-email-zohar@linux.vnet.ibm.com> References: <1470313475-20090-1-git-send-email-zohar@linux.vnet.ibm.com> <1470313475-20090-2-git-send-email-zohar@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 09 Aug 2016 20:59:51 +1000 Message-ID: <87wpjqtdg8.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mimi Zohar writes: > diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h > index b5728da..84e8d36 100644 > --- a/security/integrity/ima/ima.h > +++ b/security/integrity/ima/ima.h > @@ -102,6 +102,13 @@ struct ima_queue_entry { > }; > extern struct list_head ima_measurements; /* list of all measurements */ > > +/* Some details preceding the binary serialized measurement list */ > +struct ima_kexec_hdr { > + unsigned short version; > + unsigned long buffer_size; > + unsigned long count; > +} __packed; > + Am I understanding it correctly that this structure is passed between kernels? If so it's an ABI and should use types with well defined sizes, as if it was going out to userspace, shouldn't it? cheers