From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932838AbcDYPl1 (ORCPT ); Mon, 25 Apr 2016 11:41:27 -0400 Received: from mga11.intel.com ([192.55.52.93]:40731 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754783AbcDYPl0 (ORCPT ); Mon, 25 Apr 2016 11:41:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,533,1455004800"; d="scan'208";a="91550128" From: Alexander Shishkin To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v1 4/5] perf: Introduce address range filtering In-Reply-To: <20160425125718.GC3448@twins.programming.kicks-ass.net> References: <1461251823-12416-1-git-send-email-alexander.shishkin@linux.intel.com> <1461251823-12416-5-git-send-email-alexander.shishkin@linux.intel.com> <20160422074555.GB3448@twins.programming.kicks-ass.net> <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> <20160425125718.GC3448@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 25 Apr 2016 18:41:12 +0300 Message-ID: <87wpnl8zmv.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Fri, Apr 22, 2016 at 07:19:11PM +0300, Alexander Shishkin wrote: >> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h >> index b717902c99..4f968d6b96 100644 >> --- a/include/linux/perf_event.h >> +++ b/include/linux/perf_event.h >> @@ -151,6 +151,15 @@ struct hw_perf_event { >> */ >> struct task_struct *target; >> >> + /* >> + * PMU would store hardware filter configuration >> + * here. >> + */ >> + void *addr_filters; >> + >> + /* Last sync'ed generation of filters */ >> + unsigned long addr_filters_gen; >> + > > should these not go in the itrace struct? I wanted to decouple it from the whole 'itrace' thing, because I thought it might be usable (or at least applicable) in other contexts as well, like tracepoints, for example. Have not given it much thought yet, though. Regards, -- Alex