From: Kalle Valo <kvalo@codeaurora.org>
To: "Reizer\, Eyal" <eyalr@ti.com>
Cc: Eyal Reizer <eyalreizer@gmail.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] wlcore: spi: add wl18xx support
Date: Thu, 07 Apr 2016 17:32:08 +0300 [thread overview]
Message-ID: <87wpo97amv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B360B5430@DFRE01.ent.ti.com> (Eyal Reizer's message of "Thu, 7 Apr 2016 12:45:13 +0000")
"Reizer, Eyal" <eyalr@ti.com> writes:
>> > static const struct of_device_id wlcore_spi_of_match_table[] = {
>> > - { .compatible = "ti,wl1271" },
>> > + { .compatible = "ti,wl1271", .data = &wl12xx_data},
>> > + { .compatible = "ti,wl1273", .data = &wl12xx_data},
>> > + { .compatible = "ti,wl1281", .data = &wl12xx_data},
>> > + { .compatible = "ti,wl1283", .data = &wl12xx_data},
>> > + { .compatible = "ti,wl1801", .data = &wl18xx_data},
>> > + { .compatible = "ti,wl1805", .data = &wl18xx_data},
>> > + { .compatible = "ti,wl1807", .data = &wl18xx_data},
>> > + { .compatible = "ti,wl1831", .data = &wl18xx_data},
>> > + { .compatible = "ti,wl1835", .data = &wl18xx_data},
>> > + { .compatible = "ti,wl1837", .data = &wl18xx_data},
>> > { }
>>
>> Shouldn't you also update bindings/net/wireless/ti,wlcore,spi.txt? Now it only
>> mentions about ti,wl1271 and not anything about the rest.
>
> You are right! Will be fixed in v2
Thanks. Also remember to CC devicetree list.
--
Kalle Valo
next prev parent reply other threads:[~2016-04-07 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 13:06 Eyal Reizer
2016-04-06 7:28 ` Reizer, Eyal
2016-04-07 12:16 ` Kalle Valo
2016-04-07 12:24 ` Kalle Valo
2016-04-07 12:45 ` Reizer, Eyal
2016-04-07 14:32 ` Kalle Valo [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-30 12:58 Eyal Reizer
2016-03-30 13:02 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpo97amv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=eyalr@ti.com \
--cc=eyalreizer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome