From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760869AbcAMNtR (ORCPT ); Wed, 13 Jan 2016 08:49:17 -0500 Received: from mga04.intel.com ([192.55.52.120]:37079 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753277AbcAMNtQ (ORCPT ); Wed, 13 Jan 2016 08:49:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,289,1449561600"; d="scan'208";a="889667192" From: Alexander Shishkin To: Peter Zijlstra , mingo@kernel.org, eranian@google.com Cc: linux-kernel@vger.kernel.org, vince@deater.net, dvyukov@google.com, andi@firstfloor.org, jolsa@redhat.com Subject: Re: [RFC][PATCH 12/12] perf: Collapse and fix event_function_call() users In-Reply-To: <20160113105056.GR6357@twins.programming.kicks-ass.net> References: <20160111162458.427203780@infradead.org> <20160111163229.411314288@infradead.org> <20160113105056.GR6357@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 13 Jan 2016 15:46:58 +0200 Message-ID: <87wprd8uct.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > @@ -2250,7 +2269,11 @@ static void __perf_event_enable(struct p > if (leader != event && leader->state != PERF_EVENT_STATE_ACTIVE) > return; > > - ctx_resched(cpuctx, ctx); > + task_ctx = cpuctx->task_ctx; > + if (ctx->task) > + WARN_ON_ONCE(task_ctx != ctx); > + > + ctx_resched(cpuctx, task_ctx); Afaict, ctx_resched() path already does this in task_ctx_sched_out(). Regards, -- Alex