From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753232AbbCaKBO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 Mar 2015 06:01:14 -0400
Received: from mail-la0-f54.google.com ([209.85.215.54]:34324 "EHLO
	mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751413AbbCaKBK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 Mar 2015 06:01:10 -0400
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Sasha Levin <sasha.levin@oracle.com>,
        Cyrill Gorcunov <gorcunov@openvz.org>,
        Roman Gushchin <klamm@yandex-team.ru>, Hugh Dickins <hughd@google.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mmap.c: use while instead of if+goto
Organization: D03
References: <1427744435-6304-1-git-send-email-linux@rasmusvillemoes.dk>
	<20150330205413.GA4458@node.dhcp.inet.fi>
	<20150330145821.ca638ac21a02564cb5c04a36@linux-foundation.org>
X-Hashcash: 1:20:150331:klamm@yandex-team.ru::SEsNwjttR7y56Psn:000000000000000000000000000000000000000000a+U
X-Hashcash: 1:20:150331:gorcunov@openvz.org::hutuUB6NaxQtJ/bc:0000000000000000000000000000000000000000000d2v
X-Hashcash: 1:20:150331:akpm@linux-foundation.org::JbtEV+cbh7XDNpDz:00000000000000000000000000000000000005+/
X-Hashcash: 1:20:150331:kirill@shutemov.name::gLIEgA6zUcoW7Mft:00000000000000000000000000000000000000000118k
X-Hashcash: 1:20:150331:hughd@google.com::iv7Qa/nVguMzilAv:03MUB
X-Hashcash: 1:20:150331:sasha.levin@oracle.com::YzOvEWa2Y3Fvi75C:0000000000000000000000000000000000000004JHr
X-Hashcash: 1:20:150331:kirill.shutemov@linux.intel.com::FzZQ3p7CMtjjsdFh:0000000000000000000000000000005ZFR
X-Hashcash: 1:20:150331:linux-mm@kvack.org::mTTOxbIqqThPJXc7:00000000000000000000000000000000000000000007+XI
X-Hashcash: 1:20:150331:linux-kernel@vger.kernel.org::QseqRYw3rD04M2SI:000000000000000000000000000000000FCt/
Date: Tue, 31 Mar 2015 12:01:07 +0200
In-Reply-To: <20150330145821.ca638ac21a02564cb5c04a36@linux-foundation.org>
	(Andrew Morton's message of "Mon, 30 Mar 2015 14:58:21 -0700")
Message-ID: <87wq1xh4f0.fsf@rasmusvillemoes.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 30 2015, Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 30 Mar 2015 23:54:13 +0300 "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
>
>> On Mon, Mar 30, 2015 at 09:40:35PM +0200, Rasmus Villemoes wrote:
>> > The creators of the C language gave us the while keyword. Let's use
>> > that instead of synthesizing it from if+goto.
>> > 
>> > Made possible by 6597d783397a ("mm/mmap.c: replace find_vma_prepare()
>> > with clearer find_vma_links()").
>> > 
>> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>> 
>> 
>> Looks good, except both your plus-lines are over 80-characters long for no
>> reason.
>
> --- a/mm/mmap.c~mm-mmapc-use-while-instead-of-ifgoto-fix
> +++ a/mm/mmap.c
> @@ -1551,7 +1551,8 @@ unsigned long mmap_region(struct file *f
>
> I'm not sure it improves things a lot, but mmap.c has been pretty
> careful about the 80-col thing...

Yeah, I did run checkpatch and chose to ignore the 80-col warning, since
I think both the patch and the resulting code was more readable that
way. I don't really care either way, though.

Rasmus