From: Peter Korsgaard <peter@korsgaard.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Max Filippov <jcmvbkbc@gmail.com>,
Peter Korsgaard <jacmet@sunsite.dk>,
linux-i2c@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c-ocores: add common clock support
Date: Thu, 22 Jan 2015 19:28:21 +0100 [thread overview]
Message-ID: <87wq4e7jqy.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20150122150717.GJ3413@katana> (Wolfram Sang's message of "Thu, 22 Jan 2015 16:07:17 +0100")
>>>>> "Wolfram" == Wolfram Sang <wsa@the-dreams.de> writes:
>> The clock here is not the i2c bus clock, but the clock input of the
> Yes, what I would expect from a clk-property :)
>> controller. The function ocores_init initializes the prescaler register of
>> the controller so that the bus clock equals 100kHz (internal clock
>> runs at 500kHz):
> 'clock-frequency' usually describes the I2C bus speed. So, for ocores,
> it describes speed of the clock for the controller? That would be
> ouch...
Indeed :/
Looking back in the history, the device tree patch originally used a
custom "clock_khz" property until some guy told him to use
clock-frequency ;)
https://lists.ozlabs.org/pipermail/devicetree-discuss/2010-November/003650.html
As far as I can see I wasn't CC'ed on that patch.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2015-01-22 18:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 10:21 Max Filippov
2015-01-16 22:36 ` Peter Korsgaard
2015-01-22 14:45 ` Wolfram Sang
2015-01-22 15:01 ` Max Filippov
2015-01-22 15:07 ` Wolfram Sang
2015-01-22 18:28 ` Peter Korsgaard [this message]
2015-01-22 18:57 ` Wolfram Sang
2015-01-22 19:15 ` Max Filippov
2015-01-22 19:26 ` Wolfram Sang
2015-01-22 20:53 ` Max Filippov
2015-01-22 23:21 ` Wolfram Sang
2015-01-22 20:36 ` Max Filippov
2015-01-22 20:41 ` Wolfram Sang
2015-01-22 15:21 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wq4e7jqy.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=jacmet@sunsite.dk \
--cc=jcmvbkbc@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®