mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: "zhangwei\(Jovi\)" <jovi.zhangwei@huawei.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	Hyeoncheol Lee <cheol.lee@lge.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH 10/13] tracing/uprobes: Fetch args before reserving a ring buffer
Date: Wed, 04 Sep 2013 16:10:59 +0900	[thread overview]
Message-ID: <87wqmxrri4.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <5225C38C.2090305@huawei.com> (zhangwei's message of "Tue, 3 Sep 2013 19:10:04 +0800")

Hi Jovi,

[SNIP]

On Tue, 3 Sep 2013 19:10:04 +0800, zhangwei wrote:
>> +	if (atomic_inc_return(&uprobe_buffer_ref) == 1) {
>> +		int cpu;
>> +
>> +		uprobe_cpu_buffer = __alloc_percpu(PAGE_SIZE, PAGE_SIZE);
>> +		if (uprobe_cpu_buffer == NULL)
>> +			return -ENOMEM;
>> +
>
> Do we need add atomic_dec if allocate percpu buffer failed?

Good catch!  I'll fix it. :)

Thanks,
Namhyung


>
>> +		for_each_possible_cpu(cpu)
>> +			mutex_init(&per_cpu(uprobe_cpu_mutex, cpu));
>> +	}
>> +
>>  	WARN_ON(!uprobe_filter_is_empty(&tu->filter));

  reply	other threads:[~2013-09-04  7:11 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03  5:44 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v5) Namhyung Kim
2013-09-03  5:44 ` [PATCH 01/13] tracing/uprobes: Fix documentation of uprobe registration syntax Namhyung Kim
2013-09-03  5:44 ` [PATCH 02/13] tracing/probes: Fix basic print type functions Namhyung Kim
2013-09-03  5:44 ` [PATCH 03/13] tracing/kprobes: Move fetch functions to trace_kprobe.c Namhyung Kim
2013-09-03  5:44 ` [PATCH 04/13] tracing/kprobes: Add fetch{,_size} member into deref fetch method Namhyung Kim
2013-09-03  5:44 ` [PATCH 05/13] tracing/kprobes: Staticize stack and memory fetch functions Namhyung Kim
2013-09-03  5:44 ` [PATCH 06/13] tracing/kprobes: Factor out struct trace_probe Namhyung Kim
2013-09-03  5:44 ` [PATCH 07/13] tracing/uprobes: Convert to " Namhyung Kim
2013-09-03  5:44 ` [PATCH 08/13] tracing/kprobes: Move common functions to trace_probe.h Namhyung Kim
2013-09-03  5:44 ` [PATCH 09/13] tracing/kprobes: Integrate duplicate set_print_fmt() Namhyung Kim
2013-09-03  5:44 ` [PATCH 10/13] tracing/uprobes: Fetch args before reserving a ring buffer Namhyung Kim
2013-09-03 10:50   ` Masami Hiramatsu
2013-09-04  7:08     ` Namhyung Kim
2013-09-04  8:13       ` [PATCH v5.1 " Namhyung Kim
2013-09-03 11:10   ` [PATCH " zhangwei(Jovi)
2013-09-04  7:10     ` Namhyung Kim [this message]
2013-09-03  5:44 ` [PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions Namhyung Kim
2013-09-03  5:44 ` [PATCH 12/13] tracing/uprobes: Add more " Namhyung Kim
2013-09-03  5:44 ` [PATCH 13/13] tracing/uprobes: Add support for full argument access methods Namhyung Kim
2013-09-03  9:48   ` Masami Hiramatsu
  -- strict thread matches above, loose matches on Subject: below --
2013-10-29  6:53 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v6) Namhyung Kim
2013-10-29  6:53 ` [PATCH 10/13] tracing/uprobes: Fetch args before reserving a ring buffer Namhyung Kim
2013-10-31 18:16   ` Oleg Nesterov
2013-11-01  9:00     ` Namhyung Kim
2013-11-04  8:06     ` Namhyung Kim
2013-11-04 14:35       ` Oleg Nesterov
2013-11-05  1:12         ` Namhyung Kim
2013-11-01 15:09   ` Oleg Nesterov
2013-11-01 15:22     ` Oleg Nesterov
2013-11-03 20:20       ` Oleg Nesterov
2013-11-04  8:11         ` Namhyung Kim
2013-11-04 14:38           ` Oleg Nesterov
2013-11-05  1:17             ` Namhyung Kim
2013-08-27  8:48 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v4) Namhyung Kim
2013-08-27  8:48 ` [PATCH 10/13] tracing/uprobes: Fetch args before reserving a ring buffer Namhyung Kim
2013-08-09  8:44 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v3) Namhyung Kim
2013-08-09  8:45 ` [PATCH 10/13] tracing/uprobes: Fetch args before reserving a ring buffer Namhyung Kim
2013-08-09  9:56   ` Masami Hiramatsu
2013-08-09 16:20     ` Oleg Nesterov
2013-08-09 16:21       ` Oleg Nesterov
2013-08-10  1:26       ` zhangwei(Jovi)
2013-08-10  1:41         ` zhangwei(Jovi)
2013-08-10 14:06           ` zhangwei(Jovi)
2013-08-22 16:42     ` Steven Rostedt
2013-08-22 23:57       ` zhangwei(Jovi)
2013-08-23  1:08         ` Steven Rostedt
2013-08-27  8:07           ` Namhyung Kim
2013-08-23  4:22         ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqmxrri4.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=cheol.lee@lge.com \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=namhyung.kim@lge.com \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®