From: Namhyung Kim <namhyung@kernel.org>
To: chenggang <chenggang.qin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
chenggang <chenggang.qcg@taobao.com>,
David Ahern <dsahern@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Arjan van de Ven <arjan@linux.intel.com>,
Yanmin Zhang <yanmin.zhang@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Mike Galbraith <efault@gmx.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH]Perf: Fix Makefile to remove all "*.o" files while "make clean"
Date: Thu, 14 Mar 2013 17:41:16 +0900 [thread overview]
Message-ID: <87wqtajrv7.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1363240565-25687-1-git-send-email-chenggang.qin@gmail.com> (chenggang's message of "Thu, 14 Mar 2013 13:56:05 +0800")
Hi chenggang,
On Thu, 14 Mar 2013 13:56:05 +0800, chenggang wrote:
> From: chenggang <chenggang.qcg@taobao.com>
>
> While we run "make clean" in perf's directory, and run the command:
> "fine ./ -name *.o"
> we will get:
> ------------------------------------
> ./arch/x86/util/unwind.o
> ./arch/x86/util/header.o
> ./arch/x86/util/dwarf-regs.o
> ./util/scripting-engines/trace-event-python.o
> ./util/scripting-engines/trace-event-perl.o
> ./util/probe-finder.o
> ./util/dwarf-aux.o
> ./util/unwind.o
> ./lib/rbtree.o
> ./ui/browser.o
> ./ui/browsers/map.o
> ./ui/browsers/annotate.o
> ./ui/browsers/scripts.o
> ./ui/browsers/hists.o
> ./ui/tui/setup.o
> ./ui/tui/util.o
> ./ui/tui/helpline.o
> ./ui/tui/progress.o
> ./ui/gtk/browser.o
> ./ui/gtk/setup.o
> ./ui/gtk/util.o
> ./ui/gtk/helpline.o
> ./ui/gtk/annotate.o
> ./ui/gtk/progress.o
> ./ui/gtk/hists.o
> ./scripts/perl/Perf-Trace-Util/Context.o
> ./scripts/python/Perf-Trace-Util/Context.o
> ------------------------------------
> These ".o" files are not cleaned.
>
> This patch fixed this problem.
Hmm... They should be in $LIB_OBJS which already included in the recipe.
I guess it's missed because we skip the feature tests for "clean" (and
"tags" too) target now. Sigh.
Thanks,
Namhyung
prev parent reply other threads:[~2013-03-14 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 5:56 chenggang
2013-03-14 8:41 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqtajrv7.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=chenggang.qcg@taobao.com \
--cc=chenggang.qin@gmail.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®