From: Rusty Russell <rusty@rustcorp.com.au>
To: "Sjur Brændeland" <sjur@brendeland.net>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, sjur@brendeland.net,
dmitry.tarnyagin@stericsson.com
Subject: Re: [RFC virtio-next 0/4] Introduce CAIF Virtio and reversed Vrings
Date: Thu, 01 Nov 2012 18:11:35 +1030 [thread overview]
Message-ID: <87wqy54vo0.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1351723614-4145-1-git-send-email-sjur@brendeland.net>
Sjur Brændeland <sjur@brendeland.net> writes:
> Zero-Copy data transport on the modem is primary goal for CAIF Virtio.
> In order to achieve Zero-Copy the direction of the Virtio rings are
> flipped in the RX direction. So we have implemented the Virtio
> access-function similar to what is found in vhost.c.
So, this adds another host-side virtqueue implementation.
Can we combine them together conveniently? You pulled out more stuff
into vring.h which is a start, but it's a bit overloaded.
Perhaps we should separate the common fields into struct vring, and use
it to build:
struct vring_guest {
struct vring vr;
u16 last_used_idx;
};
struct vring_host {
struct vring vr;
u16 last_avail_idx;
};
I haven't looked closely at vhost to see what it wants, but I would
think we could share more code.
Cheers,
Rusty.
next prev parent reply other threads:[~2012-11-01 7:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 22:46 Sjur Brændeland
2012-10-31 22:46 ` [RFC virtio-next 1/4] virtio: Move definitions to header file vring.h Sjur Brændeland
2012-10-31 22:46 ` [RFC virtio-next 2/4] include/vring.h: Add support for reversed vritio rings Sjur Brændeland
2012-10-31 22:46 ` [RFC virtio-next 3/4] virtio_ring: Call callback function even when used ring is empty Sjur Brændeland
2012-10-31 22:46 ` [RFC virtio-next 4/4] caif_virtio: Add CAIF over virtio Sjur Brændeland
2012-11-01 7:41 ` Rusty Russell [this message]
2012-11-05 12:12 ` [RFC virtio-next 0/4] Introduce CAIF Virtio and reversed Vrings Sjur Brændeland
2012-11-06 2:09 ` Rusty Russell
[not found] ` <1354718230-4486-1-git-send-email-sjur@brendeland.net>
[not found] ` <20121206102750.GF10837@redhat.com>
[not found] ` <877goc0wac.fsf@rustcorp.com.au>
[not found] ` <CAJK669bP41oBhJ=MB64NS21Ag7XO5WswuTiVKCFTb96nvmyBiw@mail.gmail.com>
[not found] ` <87pq1f2rj0.fsf@rustcorp.com.au>
2013-01-10 10:30 ` [RFCv2 00/12] Introduce host-side virtio queue and CAIF Virtio Rusty Russell
2013-01-10 11:11 ` Michael S. Tsirkin
2013-01-10 18:39 ` Sjur Brændeland
2013-01-10 23:35 ` Rusty Russell
2013-01-11 6:37 ` Rusty Russell
2013-01-11 15:02 ` Sjur Brændeland
2013-01-12 0:26 ` Rusty Russell
2013-01-14 17:39 ` Michael S. Tsirkin
2013-01-16 3:13 ` Rusty Russell
2013-01-16 8:16 ` Michael S. Tsirkin
2013-01-17 2:10 ` Rusty Russell
2013-01-17 9:58 ` Michael S. Tsirkin
2013-01-21 11:55 ` Rusty Russell
2013-01-17 10:35 ` Rusty Russell
2013-01-11 14:52 ` Sjur Brændeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqy54vo0.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=dmitry.tarnyagin@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sjur@brendeland.net \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome