From: Serge Belyshev <belyshev@depni.sinp.msu.ru>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] k10temp: temperature sensor for AMD Family 10h/11h CPUs
Date: Fri, 20 Nov 2009 10:22:50 +0000 [thread overview]
Message-ID: <87ws1l5wcl.fsf@depni.sinp.msu.ru> (raw)
In-Reply-To: <4B06501B.8080509@ladisch.de> (Clemens Ladisch's message of "Fri, 20 Nov 2009 09:15:23 +0100")
> +All these processors have a sensor, but on older revisions of Family 10h
> +processors, the sensor returns inconsistent values (erratum 319). The driver
> +refuses to load with these revisions (DR-BA, DR-B2, DR-B3: some Embedded
> +Opterons on Socket F; and Quad-Core Opteron, Phenom Triple/Quad-Core, and
> +Athon Dual-Core on Socket AM2+). All later revisions (RB-C2, BL-C2, DA-C2,
> +RB-C3, HY-D0) work fine; see the list above.
Please note that erratum actually states that the sensor only "may report
inconsistent values.", not that it is always broken. As evident by my
own experience (tested with a userspace application), it actually works
perfectly on all B3 stepping processors that I have.
> +static bool __devinit has_erratum_319(void)
> +{
> + /*
> + * Erratum 319: The thermal sensor of older Family 10h processors
> + * (B steppings) is unreliable.
> + */
> + return boot_cpu_data.x86 == 0x10 && boot_cpu_data.x86_model <= 2;
> +}
...
> + if (has_erratum_319()) {
> + dev_err(&pdev->dev,
> + "unreliable CPU thermal sensor; monitoring disabled\n");
> + err = -ENODEV;
> + goto exit;
> + }
So, please provide an alternative for those who have a working sensor on a
revision B processor and want to use it.
next prev parent reply other threads:[~2009-11-20 10:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4AF91F70.10106@ladisch.de>
2009-11-20 8:15 ` Clemens Ladisch
2009-11-20 10:22 ` Serge Belyshev [this message]
2009-11-20 10:44 ` [lm-sensors] " Jean Delvare
2009-11-20 10:47 ` [PATCH v2] " Clemens Ladisch
2009-11-20 11:30 ` [lm-sensors] " Jean Delvare
2009-11-20 11:56 ` Clemens Ladisch
2009-11-20 12:18 ` Jean Delvare
2009-11-23 7:45 ` [PATCH v3] " Clemens Ladisch
2009-11-23 13:51 ` Jean Delvare
2009-11-23 15:29 ` Clemens Ladisch
2009-11-23 19:05 ` Jean Delvare
2009-11-24 8:43 ` Clemens Ladisch
2009-11-24 13:26 ` Jean Delvare
2009-11-24 14:09 ` Clemens Ladisch
2009-11-24 20:11 ` Jean Delvare
2009-11-25 9:51 ` Clemens Ladisch
2009-11-26 20:44 ` Jean Delvare
2009-11-27 13:03 ` Clemens Ladisch
2010-01-10 14:45 ` Jean Delvare
2010-01-15 9:57 ` Clemens Ladisch
2010-01-15 13:31 ` Jean Delvare
2009-11-24 8:43 ` [PATCH v4] " Clemens Ladisch
2009-11-25 19:45 ` Andrew Morton
2009-11-26 7:46 ` Clemens Ladisch
2009-11-27 15:43 ` Jean Delvare
2009-11-28 7:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws1l5wcl.fsf@depni.sinp.msu.ru \
--to=belyshev@depni.sinp.msu.ru \
--cc=akpm@linux-foundation.org \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®