From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Robert Hardy <rhardy@webcon.ca>
Cc: linux-kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: vfat unlink latency 54.6ms for 128MB files
Date: Tue, 11 Jan 2005 08:41:17 +0900 [thread overview]
Message-ID: <87wtukx36q.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <Pine.LNX.4.61.0501101703140.2235@vortex.int.webcon.net> (Robert Hardy's message of "Mon, 10 Jan 2005 17:36:59 -0500 (EST)")
Robert Hardy <rhardy@webcon.ca> writes:
> Thanks for your patchset.tar (in another thread) from:
> Thu, 30 Dec 2004 12:02:14 +0900.
>
> Based on the patch above, is an additional cond_resched() call required
> somewhere in your 2004/12/30 patchset?
>
> In your 2004/12/30 patchset, if I am reading it correctly, fat_free seems to
> have moved from cache.c to file.c and the code isn't similar enough for me
> to see where a cond_resched() could be added.
Yes. For that patchset, need to add the similar code to
fat_free_cluster() in fs/fat/fatent.c.
err = fat_write_entry(sb, &fatent, FAT_ENT_FREE);
if (err)
goto error;
if (sbi->free_clusters != -1)
sbi->free_clusters++;
cond_resched(); <--- add this line
} while (cluster != FAT_ENT_EOF);
> Perhaps you have already have a newer patchset?
Yes. I added the 8~10 patches to patchset. However, current patchset
can't compile temporarily. Sorry. Please wait for next weekend.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2005-01-10 23:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-10 1:23 Sami Farin
2005-01-10 18:38 ` OGAWA Hirofumi
2005-01-10 19:39 ` Sami Farin
2005-01-10 22:36 ` Robert Hardy
2005-01-10 23:41 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wtukx36q.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=rhardy@webcon.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome