From: Takashi Iwai <tiwai@suse.de>
To: Marco Giunta <marco_giunta@outlook.it>
Cc: Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ALSA: hda: aw88399: use auto-cleanup for ACPI subsystem ID string
Date: Sat, 31 Oct 2026 17:02:41 +0100 [thread overview]
Message-ID: <87y0bdrh7i.wl-tiwai@suse.de> (raw)
In-Reply-To: <SN6PR19MB23035A048BCAF108507B59D0FC6E2@SN6PR19MB2303.namprd19.prod.outlook.com>
On Thu, 29 Oct 2026 11:51:57 +0100,
Marco Giunta wrote:
>
> Use scope-based cleanup for the string returned by acpi_get_subsystem_id()
> instead of freeing it manually, consistent with the other cleanup
> annotations in aw88399_hda_acpi_probe() and aw88399_hda_init().
>
> This is just a code cleanup, with no functional changes intended.
>
> Signed-off-by: Marco Giunta <marco_giunta@outlook.it>
> ---
> Hi Takashi & Mark,
>
> This series contains some trivial cleanups that should (hopefully) improve
> the overall code quality. These patches are the result of me re-reviewing
> the driver code during the development of the recent firmware path change
> series.
>
> I appreciate that it's likely too late to get these into 7.4.
> Apologies for not sending them earlier, I have been quite busy these past
> few weeks.
>
> Note: for simplicity, I based everything on Takashi's tree, but if
> preferred I can resend patch 3 separately rebased on Mark's.
Applied all three patches now. thanks.
Takashi
prev parent reply other threads:[~2026-10-31 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 10:51 Marco Giunta
2026-10-29 10:51 ` [PATCH 2/3] ALSA: hda: aw88399: add missing MODULE_AUTHOR to I2C driver Marco Giunta
2026-10-29 10:51 ` [PATCH 3/3] ASoC: aw88399: move library exports to SND_SOC_AW88399_LIB namespace Marco Giunta
2026-10-29 11:19 ` Mark Brown
2026-10-31 16:02 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0bdrh7i.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=marco_giunta@outlook.it \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®