From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA891212F89 for ; Sat, 1 Aug 2026 18:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785607940; cv=none; b=pjcX8kNnPv5JKKsCNI1RmZNyEOywGl80bVwE4wtf0fLjoGPjHJuVaQIRHiNkhXg54fRAWfnWJ8F2gl+7x5d7IIvhax8F+3MU4EUS7Sr6nvjpw4UXZUW1zVB/2RT05PbBXC0YRgEIkUZ2qh5l+qxfCnaX3bWd4GEsU+ezjAsy3Oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785607940; c=relaxed/simple; bh=hD/EMiZZTXqKgxjrDpfBRRAJ1kAx9ywWk+DQrs1OG88=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=lFyzTH4QqnICtpr/YZwjyjzDhfe4oEZUMUX7MRjGrZi7QkQdqXqbAtnTEXhN1JBb6szEXErIgB/ALYTnMFkanLBjnLVpizUa/baH70QMUv2OOVTFuw+OeCoBHv40iIkOILzJW5/0CjKfOyppvuNtN9uBsRMP9tg22yvbGBmOBdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iaEjA9aB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZCWLzZsW; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iaEjA9aB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZCWLzZsW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785607938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QuTNiFWTTsXb3gAvFi53MKk8btbhasMaATEQzE79DwE=; b=iaEjA9aB/4JIqg5Hj8m1j0/9auEGjtnymoSMUSAm877p1iqePmRS60+XHzuGHD+VLrQTrA 7ASOfEfcrQ6aXsZ49NucqxyaB4rFrnb4p/yMfOLfS6+JzCEypcLwAEEzNolEYQk/13sM8W ZulEQz6HCYBXLTtA7DKjha9EvrM4EgE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-r6-PeuWfO3KH3oUrEEUbpA-1; Sat, 01 Aug 2026 14:12:01 -0400 X-MC-Unique: r6-PeuWfO3KH3oUrEEUbpA-1 X-Mimecast-MFC-AGG-ID: r6-PeuWfO3KH3oUrEEUbpA_1785607921 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4955ce558d8so8184355e9.3 for ; Sat, 01 Aug 2026 11:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785607920; x=1786212720; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QuTNiFWTTsXb3gAvFi53MKk8btbhasMaATEQzE79DwE=; b=ZCWLzZsW9EZaE400Ws+WZIOvhmCakPBloIxWf3AAhTKz0S1la3OLvkEjTKoQT5/qQB 4OVqeT+7ESqgynION8RofFSbeR3XjvsHzhARVvigMFdo7BVClpuwECufgLyDIoIm7lc0 kNlBX4renyL8Ac1T0tEYxouSdpNHyOqTxQ6g1nQqEYBzSWbAX+5iELyvGkvaIOTWHTaA D+4yxEeoVRMcEsYFI+XOmpbF3aaixPgw3waiI24eoWbPQnbd+e6bgTR+yUpHdKX+9ZXn AkAy8SmX4Z96I8I1E5npENWW4lUnjHKGaAtUwNYya0sQ4hS7oyXovqK2Bf3TX3yhzQQ2 Gfxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785607920; x=1786212720; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QuTNiFWTTsXb3gAvFi53MKk8btbhasMaATEQzE79DwE=; b=CFi9AuGldRXkFXlyVl+cw6obSvYLzwB1D1zVjS40TjGFmBLTaU8NKwIx8omRlBnMRd Es3wtrsYPQ9UFUfcd3u+GAOUPEnGus1G6LDiE8Wm/yjGyr/L0ToIs/AzPVwORjqhlE8x I2ewRGPyJAXviPmlP5KGKsj8Fah+vOOoN1FRcSiQG/IhVqyHgTYRaUf1fZJSgJOFRa7z dJI6YW8bnuRzwAA5FVN4EwKDwNsGBI3nwkucVPjmKqlWPZfJl8riqE4gKf9qnBRg+Za2 huILkVD3pJoHwDhUa7Bouh7F7b8zWfXWyjAsIwE/wAsMdMiyrUk3KL5GhKer4ORU1MXl iZFQ== X-Forwarded-Encrypted: i=1; AHgh+RpPYsCjBiq0czzGpZx4Jfk/Vpvw6QQvv/7RrI00GXUHZz4imNK9W9s6+dOfdnPYsYPZqjH7tpkYt5VAEWs=@vger.kernel.org X-Gm-Message-State: AOJu0YxUUx9eeey4Yak/NTjvXg77Nc4AJVRxbxuhv7XbJxtU6sZUyqxA nN0pZJgmWntt+Sk8g8+2fXeZ2ah01SOdGjgqoNhZ3N22yWX6aqSv2vzxUD8hU61Py51qp46xZky UQecxhTSpBiQyc94/9EGd3x2bOB5XcDQ6+G1Xsgz1Zu90ExXKF5M5oajHyH58kqolUk6GEz2h7g == X-Gm-Gg: AR+sD12TbyaTHsaUiVBfgevbEh7NeoWZhL0QWUjyd6RbozDrXfzV3yU7uZQu/3unO9Z USxPMVU7y9y8qunzuOcEddeiHhHDQbVJeJOgKo7SDdpflh94vzL1WAnbFyNjlvtyzXLRIpc0VCd mwLVnf5yxP4WWMhCX3d4+jvJS4Jyu0CjJo+zLPbDjtrtoStY/VFnPHIp2YrU0vV80AlpD4VY4s+ 6skESY9Vf5oRalbAmIFX8bEvQSEpERjRt549RpkDMsOhJuj6TJHQdBRAcKxYPasPcIWzFXNNrAM Ny1FCy2h3ax9wsdlkBCn2IzWQ/hvpugDjEM7gj+ZoB1nhFsDdEEAR0xkwGWB29tfAIBDUdtV0ZO +9v+D12JOgc0mx4n1aq/S7Y8rdc0j3GlYJ7/7gddupQT5IyeQoTtx7bNBJsg= X-Received: by 2002:a05:600c:840f:b0:493:c42e:5be0 with SMTP id 5b1f17b1804b1-4980c60705amr64842295e9.0.1785607920466; Sat, 01 Aug 2026 11:12:00 -0700 (PDT) X-Received: by 2002:a05:600c:840f:b0:493:c42e:5be0 with SMTP id 5b1f17b1804b1-4980c60705amr64841705e9.0.1785607919932; Sat, 01 Aug 2026 11:11:59 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4980878dcb4sm117791635e9.13.2026.08.01.11.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 11:11:58 -0700 (PDT) From: Javier Martinez Canillas To: Helge Deller , Jakub Turek , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] fbdev: ssd1307fb: add support for Sino Wealth SH1107 controller In-Reply-To: References: <20260731-feat-sh1107-v2-0-0d2893e44ebd@elsta.tech> <20260731-feat-sh1107-v2-1-0d2893e44ebd@elsta.tech> Date: Sat, 01 Aug 2026 20:11:57 +0200 Message-ID: <87y0epd82a.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Helge Deller writes: Hello Helge, > On 7/31/26 16:45, Jakub Turek wrote: >> The SH1107 display controller is very similar to SSD1307 but the main >> difference is that SH1107 has different memory layout and uses page mode >> adressation only. >> >> The SH1107 relies primarily on vertical page addressing mode where the >> internal 128x128 GDDRAM is split into 16 vertical pages, rather than >> the horizontal/tile addressing modes natively utilized by the >> SSD1306/SSD1307. >> >> Signed-off-by: Jakub Turek >> --- >> drivers/video/fbdev/ssd1307fb.c | 87 +++++++++++++++++++++++++++++++++++------ >> 1 file changed, 76 insertions(+), 11 deletions(-) > series applied. > Why did you apply the series? I mentioned in v1 that Jakub instead should use the KMS ssd130x driver that already support variants that use page addressing, such as the SH1106 (adding SSH1107 should be trivial). Also, Sashiko correctly pointed out that the fbdev driver doesn't support most of the properties mentioned in the DT binding schema. Now is the opposite given that you merged the DT binding patch. The ssd130x driver doesn't have support for the "sinowealth,sh1107" compatible string that is being added by patch 2/2. I guess that should post a patch to delete the ssd1307fb, to make clear that shouldn't be used anymore since we have a KMS driver that has better support. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat