From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BA8D19992C for ; Wed, 3 Sep 2025 06:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756880479; cv=none; b=GVxkON/WocrnAry0V9hlCLOKTecQ1mBEB7ttIyZnVFfNHuTBQxDf4ndkzdrmdHduFa8mrz8qLW5+kYAdN+YFOxrbSKSsimrnOB0W39r1tCaTFcEmWPuWbbJEVHl9b4Lk2EPxc895iSK3IQvid7qlL1m6Uc1gpY1JEMgV0unwSnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756880479; c=relaxed/simple; bh=NznlH5PgUYjdRJyI7ivYzbTBuMkKWeEALjW0fPj3M9g=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=U5TZLDGds2R8kqvrkpzB1mgdBSOR2ONi9wmE/jVrh2CWeAYOhIkxemH9Xhw9W1lCJllbbLv2ZaVXglmzNW+6OZw5mpBYDKEPyHPNir6Uo4XG7SKX7XSf/vXy7ucliD2ek12mkI30iVonhnT3wIZ9Qs5d2O9nHDBUT9V/9xtjVyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QOgFF4Le; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QOgFF4Le" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7590BC4CEF0; Wed, 3 Sep 2025 06:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756880475; bh=NznlH5PgUYjdRJyI7ivYzbTBuMkKWeEALjW0fPj3M9g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QOgFF4LedZbxEfKfHATx+pSSrDBulZnJOFdTjB7Hb5RX+IARuNNSGttBgxL1+Io7B d5ZzUAle8y9/OeT/5GeEoldpPPuJT/N+ip7NolMPM7t39iy3l/qKj0fiX5wq0OOqYD 2DoJK4oTd+X+kCHd9SUmxnxAV0tsMvG2WlbDH4HYVAGpws2FXaJUzVmbEmozbeGcqF tStKTAairJKSJs1oczK7dw5P4drPd4dQsuvLIwjd4rnylY8YgkVvOJJu4u4MIdwdw2 lhpij5ZkaKXOVZnQUf2fCbZFPdlAQNINrCdd5bqdynDdZmmnBcNEoxRwvhieJb+YX1 7jxiiSNEBRRlw== Received: from 93-47-110-174.ip112.fastwebnet.it ([93.47.110.174] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1utgro-00000002qgc-3rgU; Wed, 03 Sep 2025 06:21:13 +0000 Date: Wed, 03 Sep 2025 07:21:07 +0100 Message-ID: <87y0qwys30.wl-maz@kernel.org> From: Marc Zyngier To: Zenghui Yu Cc: , , , , Subject: Re: [PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation In-Reply-To: <20250903023319.1820-1-yuzenghui@huawei.com> References: <20250903023319.1820-1-yuzenghui@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 93.47.110.174 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lpieralisi@kernel.org, tglx@linutronix.de, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 03 Sep 2025 03:33:19 +0100, Zenghui Yu wrote: > > An ITS cache invalidation has been performed immediately after programming > the L2 DTE in gicv5_its_device_register(). No need to perform it again > right after a successful gicv5_its_device_register(). Indeed. And this call doesn't check it's been successful either. > > Remove it. > > Signed-off-by: Zenghui Yu > --- > drivers/irqchip/irq-gic-v5-its.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c > index 2fb58d76f521..554485f0be1f 100644 > --- a/drivers/irqchip/irq-gic-v5-its.c > +++ b/drivers/irqchip/irq-gic-v5-its.c > @@ -768,8 +768,6 @@ static struct gicv5_its_dev *gicv5_its_alloc_device(struct gicv5_its_chip_data * > goto out_dev_free; > } > > - gicv5_its_device_cache_inv(its, its_dev); > - > its_dev->its_node = its; > > its_dev->event_map = (unsigned long *)bitmap_zalloc(its_dev->num_events, GFP_KERNEL); Reviewed-by: Marc Zyngier M. -- Jazz isn't dead. It just smells funny.