mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: <broonie@kernel.org>, <andriy.shevchenko@linux.intel.com>,
	<13564923607@139.com>, <13916275206@139.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
	<baojun.xu@ti.com>, <Baojun.Xu@fpt.com>, <robinchen@ti.com>
Subject: Re: [RESEND PATCH v2] ALSA: hda/tas2781: Create a common header for both spi and i2c tas2781 hda driver
Date: Tue, 15 Apr 2025 17:18:13 +0200	[thread overview]
Message-ID: <87y0w1xxl6.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250415070913.679-1-shenghao-ding@ti.com>

On Tue, 15 Apr 2025 09:09:13 +0200,
Shenghao Ding wrote:
> 
> Move the common macro definition of kcontrols into a common header.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
> 
> ---
> v2:
>  - Follow IWYU principle, add sound/asound.h into the header file.
> v1:
>  - Revise the year of spi and i2c tas2781 hda drivers.
>  - Create a common header for both spi and i2c tas2781 hda driver to define
>    the common macros and declare the common functions.

The code change itself looks fine, but do you need this change for
what purpose?  Is it meant as a code cleanup?  You wrote what the
patch does, but why it's needed isn't mentioned at all.


thanks,

Takashi

> ---
>  sound/pci/hda/tas2781_hda.h     | 44 +++++++++++++++++++++++++++++++++
>  sound/pci/hda/tas2781_hda_i2c.c | 29 ++--------------------
>  sound/pci/hda/tas2781_hda_spi.c | 35 ++------------------------
>  3 files changed, 48 insertions(+), 60 deletions(-)
>  create mode 100644 sound/pci/hda/tas2781_hda.h
> 
> diff --git a/sound/pci/hda/tas2781_hda.h b/sound/pci/hda/tas2781_hda.h
> new file mode 100644
> index 000000000000..fc741fac419a
> --- /dev/null
> +++ b/sound/pci/hda/tas2781_hda.h
> @@ -0,0 +1,44 @@
> +/* SPDX-License-Identifier: GPL-2.0-only
> + *
> + * HDA audio driver for Texas Instruments TAS2781 smart amp
> + *
> + * Copyright (C) 2025 Texas Instruments, Inc.
> + */
> +#ifndef __TAS2781_HDA_H__
> +#define __TAS2781_HDA_H__
> +
> +#include <sound/asound.h>
> +
> +/*
> + * No standard control callbacks for SNDRV_CTL_ELEM_IFACE_CARD
> + * Define two controls, one is Volume control callbacks, the other is
> + * flag setting control callbacks.
> + */
> +
> +/* Volume control callbacks for tas2781 */
> +#define ACARD_SINGLE_RANGE_EXT_TLV(xname, xreg, xshift, xmin, xmax, xinvert, \
> +	xhandler_get, xhandler_put, tlv_array) { \
> +	.iface = SNDRV_CTL_ELEM_IFACE_CARD, .name = (xname), \
> +	.access = SNDRV_CTL_ELEM_ACCESS_TLV_READ | \
> +		SNDRV_CTL_ELEM_ACCESS_READWRITE, \
> +	.tlv.p = (tlv_array), \
> +	.info = snd_soc_info_volsw, \
> +	.get = xhandler_get, .put = xhandler_put, \
> +	.private_value = (unsigned long)&(struct soc_mixer_control) { \
> +		.reg = xreg, .rreg = xreg, \
> +		.shift = xshift, .rshift = xshift,\
> +		.min = xmin, .max = xmax, .invert = xinvert, \
> +	} \
> +}
> +
> +/* Flag control callbacks for tas2781 */
> +#define ACARD_SINGLE_BOOL_EXT(xname, xdata, xhandler_get, xhandler_put) { \
> +	.iface = SNDRV_CTL_ELEM_IFACE_CARD, \
> +	.name = xname, \
> +	.info = snd_ctl_boolean_mono_info, \
> +	.get = xhandler_get, \
> +	.put = xhandler_put, \
> +	.private_value = xdata, \
> +}
> +
> +#endif
> diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
> index 29dc4f500580..9d94ae5fcfe0 100644
> --- a/sound/pci/hda/tas2781_hda_i2c.c
> +++ b/sound/pci/hda/tas2781_hda_i2c.c
> @@ -2,7 +2,7 @@
>  //
>  // TAS2781 HDA I2C driver
>  //
> -// Copyright 2023 - 2024 Texas Instruments, Inc.
> +// Copyright 2023 - 2025 Texas Instruments, Inc.
>  //
>  // Author: Shenghao Ding <shenghao-ding@ti.com>
>  // Current maintainer: Baojun Xu <baojun.xu@ti.com>
> @@ -30,35 +30,10 @@
>  #include "hda_component.h"
>  #include "hda_jack.h"
>  #include "hda_generic.h"
> +#include "tas2781_hda.h"
>  
>  #define TASDEVICE_SPEAKER_CALIBRATION_SIZE	20
>  
> -/* No standard control callbacks for SNDRV_CTL_ELEM_IFACE_CARD
> - * Define two controls, one is Volume control callbacks, the other is
> - * flag setting control callbacks.
> - */
> -
> -/* Volume control callbacks for tas2781 */
> -#define ACARD_SINGLE_RANGE_EXT_TLV(xname, xreg, xshift, xmin, xmax, xinvert, \
> -	xhandler_get, xhandler_put, tlv_array) \
> -{	.iface = SNDRV_CTL_ELEM_IFACE_CARD, .name = (xname),\
> -	.access = SNDRV_CTL_ELEM_ACCESS_TLV_READ |\
> -		 SNDRV_CTL_ELEM_ACCESS_READWRITE,\
> -	.tlv.p = (tlv_array), \
> -	.info = snd_soc_info_volsw, \
> -	.get = xhandler_get, .put = xhandler_put, \
> -	.private_value = (unsigned long)&(struct soc_mixer_control) \
> -		{.reg = xreg, .rreg = xreg, .shift = xshift, \
> -		 .rshift = xshift, .min = xmin, .max = xmax, \
> -		 .invert = xinvert} }
> -
> -/* Flag control callbacks for tas2781 */
> -#define ACARD_SINGLE_BOOL_EXT(xname, xdata, xhandler_get, xhandler_put) \
> -{	.iface = SNDRV_CTL_ELEM_IFACE_CARD, .name = xname, \
> -	.info = snd_ctl_boolean_mono_info, \
> -	.get = xhandler_get, .put = xhandler_put, \
> -	.private_value = xdata }
> -
>  enum calib_data {
>  	R0_VAL = 0,
>  	INV_R0,
> diff --git a/sound/pci/hda/tas2781_hda_spi.c b/sound/pci/hda/tas2781_hda_spi.c
> index 399f2e4c3b62..c6be2be1b53e 100644
> --- a/sound/pci/hda/tas2781_hda_spi.c
> +++ b/sound/pci/hda/tas2781_hda_spi.c
> @@ -2,7 +2,7 @@
>  //
>  // TAS2781 HDA SPI driver
>  //
> -// Copyright 2024 Texas Instruments, Inc.
> +// Copyright 2024 - 2025 Texas Instruments, Inc.
>  //
>  // Author: Baojun Xu <baojun.xu@ti.com>
>  
> @@ -38,38 +38,7 @@
>  #include "hda_component.h"
>  #include "hda_jack.h"
>  #include "hda_generic.h"
> -
> -/*
> - * No standard control callbacks for SNDRV_CTL_ELEM_IFACE_CARD
> - * Define two controls, one is Volume control callbacks, the other is
> - * flag setting control callbacks.
> - */
> -
> -/* Volume control callbacks for tas2781 */
> -#define ACARD_SINGLE_RANGE_EXT_TLV(xname, xreg, xshift, xmin, xmax, xinvert, \
> -	xhandler_get, xhandler_put, tlv_array) { \
> -	.iface = SNDRV_CTL_ELEM_IFACE_CARD, .name = (xname), \
> -	.access = SNDRV_CTL_ELEM_ACCESS_TLV_READ | \
> -		SNDRV_CTL_ELEM_ACCESS_READWRITE, \
> -	.tlv.p = (tlv_array), \
> -	.info = snd_soc_info_volsw, \
> -	.get = xhandler_get, .put = xhandler_put, \
> -	.private_value = (unsigned long)&(struct soc_mixer_control) { \
> -		.reg = xreg, .rreg = xreg, \
> -		.shift = xshift, .rshift = xshift,\
> -		.min = xmin, .max = xmax, .invert = xinvert, \
> -	} \
> -}
> -
> -/* Flag control callbacks for tas2781 */
> -#define ACARD_SINGLE_BOOL_EXT(xname, xdata, xhandler_get, xhandler_put) { \
> -	.iface = SNDRV_CTL_ELEM_IFACE_CARD, \
> -	.name = xname, \
> -	.info = snd_ctl_boolean_mono_info, \
> -	.get = xhandler_get, \
> -	.put = xhandler_put, \
> -	.private_value = xdata, \
> -}
> +#include "tas2781_hda.h"
>  
>  struct tas2781_hda {
>  	struct tasdevice_priv *priv;
> -- 
> 2.34.1
> 

      reply	other threads:[~2025-04-15 15:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15  7:09 Shenghao Ding
2025-04-15 15:18 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0w1xxl6.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=13564923607@139.com \
    --cc=13916275206@139.com \
    --cc=Baojun.Xu@fpt.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robinchen@ti.com \
    --cc=shenghao-ding@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®