From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99E3B1F03C7 for ; Fri, 14 Mar 2025 10:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741947210; cv=none; b=LZIGiaYs1un1vH3Pb0rhcB4gGc7ZaYbiKHQKJuoGKRw7V2I2UvOjAbJGmu8nteM8nIW503sBOEpE5q8jEcNecrLJt1GeAEiO2OtVC2LYwhaJ0QTOSETQESmiaNXB4fIJNmQKlgTBb6RnQA3RhOhLylEeIqYzs4ciOokov0pthfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741947210; c=relaxed/simple; bh=3fLWeHLKHrb18Uy/MS3QJBRi1rm/wOaI7DMw2a8UkqY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ZbCQPTLdb9vmVin/pTs/2+WbLUfOpz4+/ssUt3wyHxGRjhw8DtV8TRyAmq7gvOhv+GlKJp+dZS84jJyG4W0s07zshmmuyUbpaB1aKeX21KCxVXRaeVStr8idAx+dIMKe6CzxiiE31bTWDVf35g5GQGr+YwvFNXZ677AqqRZw6wU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hui0RsCL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hui0RsCL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741947207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SPd+EnkY0Li2mTO/GP70bxnkH1XCMqHnQAmmracRGtI=; b=hui0RsCLXrGu0G7zqLYhtgvrcDYAesZiooZ6iceleb/RzBG+99WWziCuOHcKEKPyXLPZZC 6v5KL5+nu2v8R52fCT1IecOjA8ZRlsSoAk7qBVcfvFFckebY1V6YsFS26HNuUXPpKbjYqE sSEAI9qoXXN2SDFCWgUW05calS+4KBk= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-5K3aqZgcNL-bB163s3UzOQ-1; Fri, 14 Mar 2025 06:13:26 -0400 X-MC-Unique: 5K3aqZgcNL-bB163s3UzOQ-1 X-Mimecast-MFC-AGG-ID: 5K3aqZgcNL-bB163s3UzOQ_1741947205 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-ac2aa3513ccso170421366b.0 for ; Fri, 14 Mar 2025 03:13:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741947205; x=1742552005; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SPd+EnkY0Li2mTO/GP70bxnkH1XCMqHnQAmmracRGtI=; b=GwlhafFmCDKGdc2Nxaz/4E5Uw70OBiXIylyZCp6WPFfk/q+XSHg4IwggsO+xh4ZNpS ltlbQbAcTbW64fZgwv7+IjKoMK0b9pza333qC+TGWA+UE4daIbscqr5L/M5/cqzMiaJr geJeqZJK0DkODVh2mjWQccEcjQKRvKEdOf9PLCFOm3SljXbdJcGZ20FLAdc5j82A7lJ6 4hHFZKPeQ1K7qj1CLseskwFKEjMKgpkrlSrue2gKyjTnAM+641Zd8f7r6FH1elpERG2p yYHHZ8AcGDvNIGUdfN6l1eRRVP4wLvVb92pOBVWM9WzkoJmFVuZdYZ5L5EoAsBw0YDv1 ICbQ== X-Forwarded-Encrypted: i=1; AJvYcCUxjGc3uXS4n+gH8ChZ1kzP6iBfbS34Qcl6vWWOLi4srrOqno52eyWAi0Td7ln0zSymtbYG4O3F86FERis=@vger.kernel.org X-Gm-Message-State: AOJu0YykQwZ2vDipsKeL3XQp6rhj/VANeLHWhzpgpAdWKip8XF0Hq/Zu 97oF5Vk4ecQTaKmNJSqLDfkl65vUXE9rfGvT43HnUp6c4hm+IvDTxyVE8x8o8KHMaD5Ysn4EubQ 81aHh0Yu9txOhcy6Xgsh7moLhTweY1qYNvNKd/XI04UiHMNMRbt5JgLfZkoOR2w== X-Gm-Gg: ASbGnct17CWOkkCb4TdoyWQPDUaJW4VbFwPtF4019HvTS05AK77n0TzpN6oYog35V5u XA187QRKs9iPiyIX4gXFgY2yB09ABnOgVLw1doQS+qRTOYwYOqs7np+r50OVj5hXPG2Vg6T8rH2 cApKGSKrO/4sV3SIzg9Dqk7+77WGKVnZZrNg7S0OvlFsEJnivQdeFNueMeugqrbU9qmFZqexeD0 5qqWWPsX6t02BluwcSPs1rlwH5e8gJC55Le0bGXamN46idFtRSwkRSgX/B0NmU43vNstrEqUvyI SmV73SoWKKmn X-Received: by 2002:a17:907:7d87:b0:ac3:26fb:f420 with SMTP id a640c23a62f3a-ac3303715c9mr200508866b.42.1741947204948; Fri, 14 Mar 2025 03:13:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSV3Kxn90NGxgDHQH3cs1oxAKHVeo2b8VKgG0w+cX9fVNQ1pDU9yg6oVegNwiT56KvNkO8iQ== X-Received: by 2002:a17:907:7d87:b0:ac3:26fb:f420 with SMTP id a640c23a62f3a-ac3303715c9mr200503466b.42.1741947204252; Fri, 14 Mar 2025 03:13:24 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3146aeb5asm204715966b.36.2025.03.14.03.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 03:13:23 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 27E5218FA934; Fri, 14 Mar 2025 11:13:15 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Wang Liang , jv@jvosburgh.net, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, joamaki@gmail.com Cc: yuehaibing@huawei.com, zhangchangzhong@huawei.com, wangliang74@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net] bonding: check xdp prog when set bond mode In-Reply-To: <20250314073549.1030998-1-wangliang74@huawei.com> References: <20250314073549.1030998-1-wangliang74@huawei.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 14 Mar 2025 11:13:15 +0100 Message-ID: <87y0x7rkck.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Wang Liang writes: > Following operations can trigger a warning[1]: > > ip netns add ns1 > ip netns exec ns1 ip link add bond0 type bond mode balance-rr > ip netns exec ns1 ip link set dev bond0 xdp obj af_xdp_kern.o sec xdp > ip netns exec ns1 ip link set bond0 type bond mode broadcast > ip netns del ns1 > > When delete the namespace, dev_xdp_uninstall() is called to remove xdp > program on bond dev, and bond_xdp_set() will check the bond mode. If bond > mode is changed after attaching xdp program, the warning may occur. > > Some bond modes (broadcast, etc.) do not support native xdp. Set bond mode > with xdp program attached is not good. Add check for xdp program when set > bond mode. > > [1] > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 11 at net/core/dev.c:9912 unregister_netdevice_many_notify+0x8d9/0x930 > Modules linked in: > CPU: 0 UID: 0 PID: 11 Comm: kworker/u4:0 Not tainted 6.14.0-rc4 #107 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.15.0-0-g2dd4b9b3f840-prebuilt.qemu.org 04/01/2014 > Workqueue: netns cleanup_net > RIP: 0010:unregister_netdevice_many_notify+0x8d9/0x930 > Code: 00 00 48 c7 c6 6f e3 a2 82 48 c7 c7 d0 b3 96 82 e8 9c 10 3e ... > RSP: 0018:ffffc90000063d80 EFLAGS: 00000282 > RAX: 00000000ffffffa1 RBX: ffff888004959000 RCX: 00000000ffffdfff > RDX: 0000000000000000 RSI: 00000000ffffffea RDI: ffffc90000063b48 > RBP: ffffc90000063e28 R08: ffffffff82d39b28 R09: 0000000000009ffb > R10: 0000000000000175 R11: ffffffff82d09b40 R12: ffff8880049598e8 > R13: 0000000000000001 R14: dead000000000100 R15: ffffc90000045000 > FS: 0000000000000000(0000) GS:ffff888007a00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 000000000d406b60 CR3: 000000000483e000 CR4: 00000000000006f0 > Call Trace: > > ? __warn+0x83/0x130 > ? unregister_netdevice_many_notify+0x8d9/0x930 > ? report_bug+0x18e/0x1a0 > ? handle_bug+0x54/0x90 > ? exc_invalid_op+0x18/0x70 > ? asm_exc_invalid_op+0x1a/0x20 > ? unregister_netdevice_many_notify+0x8d9/0x930 > ? bond_net_exit_batch_rtnl+0x5c/0x90 > cleanup_net+0x237/0x3d0 > process_one_work+0x163/0x390 > worker_thread+0x293/0x3b0 > ? __pfx_worker_thread+0x10/0x10 > kthread+0xec/0x1e0 > ? __pfx_kthread+0x10/0x10 > ? __pfx_kthread+0x10/0x10 > ret_from_fork+0x2f/0x50 > ? __pfx_kthread+0x10/0x10 > ret_from_fork_asm+0x1a/0x30 > > ---[ end trace 0000000000000000 ]--- > > Fixes: 9e2ee5c7e7c3 ("net, bonding: Add XDP support to the bonding driver") > Signed-off-by: Wang Liang > --- > drivers/net/bonding/bond_options.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c > index 327b6ecdc77e..127181866829 100644 > --- a/drivers/net/bonding/bond_options.c > +++ b/drivers/net/bonding/bond_options.c > @@ -868,6 +868,9 @@ static bool bond_set_xfrm_features(struct bonding *bond) > static int bond_option_mode_set(struct bonding *bond, > const struct bond_opt_value *newval) > { > + if (bond->xdp_prog) > + return -EOPNOTSUPP; > + Should we allow changing as long as the new mode also supports XDP? -Toke