From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5BC5C77B7F for ; Mon, 8 May 2023 07:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233306AbjEHHiD (ORCPT ); Mon, 8 May 2023 03:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbjEHHh7 (ORCPT ); Mon, 8 May 2023 03:37:59 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D63B5B96 for ; Mon, 8 May 2023 00:37:58 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C1E4821AC0; Mon, 8 May 2023 07:37:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683531476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YqInM1342hBU+JGe1iQkO4roq6FUOaOXw8p0I5kqNRs=; b=mtarhdO3ra1s5OiLWG+Ju19yqxd1rtL/boRsvziIuReE5Y5zcwq5enIqc20ObcGS+OcJaV 5gRGzfLkxNM/+cuyMoiSofLzsVzQrYChMJG97SzYWdpUB/MTBDDIVTd9qItO9SMZjXYThz kp8V6jhHbDyVGb8TIWtvNj4uKUs+ARk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683531476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YqInM1342hBU+JGe1iQkO4roq6FUOaOXw8p0I5kqNRs=; b=5Kye1D0ByhCf4HBc1zihGsjgV6frE9AoIIYmjc/zQbbkyvtE7SevX713PfNPefVVRQt+YK PyNuxlYbKCpb4pAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 94F2B1346B; Mon, 8 May 2023 07:37:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id r38aI9SmWGRiOAAAMHmgww (envelope-from ); Mon, 08 May 2023 07:37:56 +0000 Date: Mon, 08 May 2023 09:37:56 +0200 Message-ID: <87y1lze0iz.wl-tiwai@suse.de> From: Takashi Iwai To: jack1989s@gmail.com Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Sound:last.c: fix code syle trailing white space - modify printk()->netdev_dbg() - Possible unnecessary KERN_INFO removed In-Reply-To: <20230507130021.48112-1-jack1989s@gmail.com> References: <20230507130021.48112-1-jack1989s@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 07 May 2023 15:00:21 +0200, jack1989s@gmail.com wrote: > > From: Federico Di Lembo > > Fixing coding style. > > Signed-off-by: Federico Di Lembo In general, we don't take a patch just for white space without any real need. Please do a cleanup together with other real fix or enhancement patches. Also, the use of netdev_dbg() doesn't make sense here at all; the code has nothing to do with the network. Last but not least, you change the printk level by the conversion silently. It's really bad, please don't. If you have to change the printk level, give the convincing explanation. thanks, Takashi > --- > sound/last.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/last.c b/sound/last.c > index f0bb98780e70..b8cfd6ded95d 100644 > --- a/sound/last.c > +++ b/sound/last.c > @@ -11,18 +11,18 @@ static int __init alsa_sound_last_init(void) > { > struct snd_card *card; > int idx, ok = 0; > - > - printk(KERN_INFO "ALSA device list:\n"); > + > + netdev_dbg("ALSA device list:\n"); > for (idx = 0; idx < SNDRV_CARDS; idx++) { > card = snd_card_ref(idx); > if (card) { > - printk(KERN_INFO " #%i: %s\n", idx, card->longname); > + netdev_dbg(" #%i: %s\n", idx, card->longname); > snd_card_unref(card); > ok++; > } > } > if (ok == 0) > - printk(KERN_INFO " No soundcards found.\n"); > + netdev_dbg(" No soundcards found.\n"); > return 0; > } > > -- > 2.34.1 >