From: Jonathan Corbet <corbet@lwn.net>
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>,
linux-doc@vger.kernel.org
Cc: Alexander Sverdlin <alexander.sverdlin@siemens.com>,
Federico Vaga <federico.vaga@vaga.pv.it>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Manfred Spraul <manfred@colorfullife.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: kernel-hacking: discourage from calling disable_irq() in atomic
Date: Wed, 11 Jan 2023 15:46:18 -0700 [thread overview]
Message-ID: <87y1q8wuyt.fsf@meer.lwn.net> (raw)
In-Reply-To: <20221223112859.937196-1-alexander.sverdlin@siemens.com>
"A. Sverdlin" <alexander.sverdlin@siemens.com> writes:
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
> Correct the example in documentation so that disable_irq() is not being
> called in atomic context.
>
> disable_irq() calls sleeping synchronize_irq(), it's not allowed to call
> them in atomic context.
>
> Link: https://lore.kernel.org/lkml/87k02wbs2n.ffs@tglx/
> Reviewed-by: Manfred Spraul <manfred@colorfullife.com>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> ---
> Changelog:
> v2: Dropped changes to manage.c because of already applied
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kernel-irq-managec-disable_irq-might-sleep.patch
>
> Documentation/kernel-hacking/locking.rst | 4 ++--
> Documentation/translations/it_IT/kernel-hacking/locking.rst | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
jon
prev parent reply other threads:[~2023-01-11 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 11:28 A. Sverdlin
2023-01-11 22:46 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1q8wuyt.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=alexander.sverdlin@siemens.com \
--cc=federico.vaga@vaga.pv.it \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®