From: ebiederm@xmission.com (Eric W. Biederman)
To: Michal Suchanek <msuchanek@suse.de>
Cc: linuxppc-dev@lists.ozlabs.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Steven Rostedt" <rostedt@goodmis.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Firoz Khan <firoz.khan@linaro.org>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Nicholas Piggin <npiggin@gmail.com>,
Hari Bathini <hbathini@linux.ibm.com>,
Joel Stanley <joel@jms.id.au>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Breno Leitao <leitao@debian.org>,
Allison Randal <allison@lohutok.net>,
Michael Neuling <mikey@neuling.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] fs: always build llseek.
Date: Wed, 28 Aug 2019 13:16:55 -0500 [thread overview]
Message-ID: <87y2zdxii0.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <8736hlyx8r.fsf@x220.int.ebiederm.org> (Eric W. Biederman's message of "Wed, 28 Aug 2019 13:13:08 -0500")
ebiederm@xmission.com (Eric W. Biederman) writes:
> Michal Suchanek <msuchanek@suse.de> writes:
>
>> 64bit !COMPAT does not build because the llseek syscall is in the
>> tables.
>
> Do I read this right you have a 128 bit offset to llseek on ppc64?
>
> Looking at the signature it does not appear to make sense to build this
> function on any 64bit platform.
>
> Perhaps the proper fix to to take llseek out of your syscall tables?
Sorry I missed seeing the 2 newer version of the patchset in my inbox
it seems you have already made the change I am suggesting.
Never mind.
Eric
next prev parent reply other threads:[~2019-08-28 18:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 20:21 [PATCH 0/4] Disable compat cruft on ppc64le Michal Suchanek
2019-08-27 20:21 ` [PATCH 1/4] fs: always build llseek Michal Suchanek
2019-08-28 15:15 ` Christoph Hellwig
2019-08-28 16:15 ` Michal Suchánek
2019-08-29 6:22 ` Christoph Hellwig
2019-08-29 10:06 ` Michal Suchánek
2019-08-28 18:13 ` Eric W. Biederman
2019-08-28 18:16 ` Eric W. Biederman [this message]
2019-08-27 20:21 ` [PATCH 2/4] powerpc: move common register copy functions from signal_32.c to signal.c Michal Suchanek
2019-08-27 20:21 ` [PATCH 3/4] powerpc/64: make buildable without CONFIG_COMPAT Michal Suchanek
2019-08-27 20:36 ` Michal Suchánek
2019-08-27 20:21 ` [PATCH 4/4] powerpc/64: Disable COMPAT if littleendian Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2zdxii0.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=allison@lohutok.net \
--cc=andrew.donnellan@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=david@redhat.com \
--cc=firoz.khan@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hbathini@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=joel@jms.id.au \
--cc=ldv@altlinux.org \
--cc=leitao@debian.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome