From: "Bjørn Mork" <bjorn@mork.no>
To: Dan Williams <dcbw@redhat.com>
Cc: Lars Melin <larsm17@gmail.com>,
Kristian Evensen <kristian.evensen@gmail.com>,
Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] option: Improve Quectel EP06 detection
Date: Wed, 12 Sep 2018 22:34:43 +0200 [thread overview]
Message-ID: <87y3c6a1zw.fsf@miraculix.mork.no> (raw)
In-Reply-To: <f3c647ec7c50ae390fb92861d492e7aa4bef8c6f.camel@redhat.com> (Dan Williams's message of "Wed, 12 Sep 2018 14:18:05 -0500")
Dan Williams <dcbw@redhat.com> writes:
> The fact that the firmware implementation has the ability to change the
> endpoints is unrelated to Kristian's case, and that alone is
> justification for this to be quirked in the driver. People other than
> Kristian will undoubtedly use the functionality, on platforms less
> limited.
FWIW, I agree with Dan and Kristian on this. It's a documented feature,
and it will be used. The reasons are irrelevant. The firmware
implementation is inconvenient, but we should still strive to make it
Just Work in Linux. Kristian's solution does that.
> Also most Huawei modems have the ability to change their layout and
> configuration just like the EP06 via the U2DIAG and SETPORT commands.
Yes, but they are nice enough to use unique class/subclass/protocol
triplets for their functions so it's easy to support the changing
layout. At least as long as they use their own VID and not some laptop
vendor's..
The Sierra Wireless strategy, using fixed interface numbers leaving
"holes" is another fine solution to the problem. Or they could have
allocated unique VIDs per function combination, as long as the number of
valid combinations are low. But they didn't. It's not like it's the
first bad firmware design we've had to deal with. Let's just work
around it, like we always do. No need to make life difficult for end
users just because Quectel makes life difficult for us.
Bjørn
next prev parent reply other threads:[~2018-09-12 20:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 12:57 Kristian Evensen
2018-09-10 10:30 ` Johan Hovold
2018-09-10 11:39 ` Kristian Evensen
2018-09-11 14:00 ` Lars Melin
2018-09-11 14:34 ` Kristian Evensen
2018-09-12 16:32 ` Lars Melin
2018-09-12 16:57 ` Kristian Evensen
2018-09-12 18:25 ` Lars Melin
2018-09-12 19:18 ` Dan Williams
2018-09-12 20:34 ` Bjørn Mork [this message]
2018-09-13 9:17 ` Johan Hovold
2018-09-13 9:21 ` [PATCH 1/2] USB: serial: option: improve " Johan Hovold
2018-09-13 9:21 ` [PATCH 2/2] USB: serial: option: add two-endpoints device-id flag Johan Hovold
2018-09-13 9:44 ` [PATCH] option: Improve Quectel EP06 detection Kristian Evensen
2018-09-13 15:13 ` Kristian Evensen
2018-09-14 7:51 ` Johan Hovold
2018-09-14 7:53 ` Kristian Evensen
2018-09-14 8:42 ` Johan Hovold
2018-09-10 14:43 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3c6a1zw.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=dcbw@redhat.com \
--cc=johan@kernel.org \
--cc=kristian.evensen@gmail.com \
--cc=larsm17@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®