From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755234AbeAOKoU (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 15 Jan 2018 05:44:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54932 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755114AbeAOKoS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Jan 2018 05:44:18 -0500
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: kvm@vger.kernel.org, x86@kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "Michael Kelley \(EOSG\)" <Michael.H.Kelley@microsoft.com>,
        Andy Lutomirski <luto@kernel.org>,
        Mohammed Gamal <mmorsy@redhat.com>,
        Cathy Avery <cavery@redhat.com>,
        Roman Kagan <rkagan@virtuozzo.com>,
        linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH v2 4/7] x86/hyper-v: redirect reenlightment notifications on CPU offlining
References: <20171213150945.24054-1-vkuznets@redhat.com>
        <20171213150945.24054-5-vkuznets@redhat.com>
        <alpine.DEB.2.20.1801142142280.2371@nanos>
Date: Mon, 15 Jan 2018 11:44:12 +0100
In-Reply-To: <alpine.DEB.2.20.1801142142280.2371@nanos> (Thomas Gleixner's
        message of "Sun, 14 Jan 2018 21:44:38 +0100 (CET)")
Message-ID: <87y3kziepv.fsf@vitty.brq.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 15 Jan 2018 10:44:17 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Thomas Gleixner <tglx@linutronix.de> writes:

> On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote:
>> +static int hv_cpu_die(unsigned int cpu)
>> +{
>> +	struct hv_reenlightenment_control re_ctrl;
>> +	int i;
>> +	static DEFINE_SPINLOCK(lock);
>> +
>> +	if (hv_reenlightenment_cb == NULL)
>> +		return 0;
>> +
>> +	/* Make sure the CPU we migrate to is not going away too */
>> +	spin_lock(&lock);
>
> What kind of voodoo is this? CPU hotplug is serialized already...
>

Yes, someone around made a comment 'what happens if some day we'll have
parallel cpu hot[un]plug' and I added this. Not really needed, will drop
in v3.

>> +	rdmsrl(HV_X64_MSR_REENLIGHTENMENT_CONTROL, *((u64 *)&re_ctrl));
>> +	if (re_ctrl.target_vp == hv_vp_index[cpu]) {
>> +		/* Find some other online CPU */
>> +		for_each_online_cpu(i) {
>
>   		cpu = cpumask_any_but(cpu_online_mask);
>
> Hmm?
>

Cool, thanks)

-- 
  Vitaly