From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757728AbeAHVja (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 16:39:30 -0500
Received: from mx2.suse.de ([195.135.220.15]:50683 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757572AbeAHVj2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 16:39:28 -0500
From: NeilBrown <neilb@suse.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Tue, 09 Jan 2018 08:39:17 +1100
Cc: Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        James Simmons <jsimmons@infradead.org>,
        lkml <linux-kernel@vger.kernel.org>,
        lustre <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 03/15] staging: lustre: replace simple cases of LIBCFS_ALLOC with kzalloc.
In-Reply-To: <20180108145157.GA32570@kroah.com>
References: <151355781721.6200.2136335532722530242.stgit@noble> <151355799030.6200.8100283223734974485.stgit@noble> <20180108145157.GA32570@kroah.com>
Message-ID: <87y3l8av3u.fsf@notabene.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 08 2018, Greg Kroah-Hartman wrote:

> On Mon, Dec 18, 2017 at 11:46:30AM +1100, NeilBrown wrote:
>> All usages of the form
>>   LIBCFS_ALLOC(variable, sizeof(variable))
>> or
>>   LIBCFS_ALLOC(variable, sizeof(variable's-type))
>>=20
>> are changed to
>>   variable =3D kzalloc(sizeof(...), GFP_NOFS);
>>=20
>> Similarly, all
>>    LIBCFS_FREE(variable, sizeof(variable))
>> become
>>    kfree(variable);
>>=20
>> None of these need the vmalloc option, or any of the other minor
>> benefits of LIBCFS_ALLOC().
>>=20
>> Signed-off-by: NeilBrown <neilb@suse.com>
>
> As this broke the kbuild system, I'll stop here in this patch series.
> Can you please fix it up, rebase and resend the remaining ones in this
> series?

Hi Greg,
 thanks for applying the patches.

 That patch had a typo in code that was only included if CONFIG_INFINIBAND =
is
 enabled, which I didn't have in my testing at the time.  I hadn't
 resent when I fixed it as I was waiting to see if there would be
 feedback.
 If the protocol is "you apply sometime after two weeks if there is no
 feedback (and no breakage)", then I'll aim to work with that.

 I'll resend with the rest of the kmalloc patches.

Thanks,
NeilBrown


=20

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlpT5QYACgkQOeye3VZi
gbm8Ew/9GnB+DwTJcEOlfr9aPZMCkG0TwTpZXNQU4+fT3tLW81B1O9HFhLFnaHmQ
77NZ6iAwneYbArE9lX0X84jbV+Z8kUukbelM821VbVh66BMpnLFEYw2Obw0bgmoh
hHhLj6/4kCq3iGQN9KCd4rzKWDRrBLm/mesd21ILxZMEliGmqMnbCIXYiHJ4VXE3
yBeERUch81hg6tqCTwdP23SUp6eugxZRKs04j6kQfMkIDzyKfC2RDKRS/duA7ZAb
YeQvXUSjA1EftIv+j2dasTgLo65t/cS5Qq0I7FwrMg0iKvZVAxeSQhQjGo6CkhGq
y32iHdA+rTiEr3/8+U6lv8xD2fPvYDSoySl9tW/RXlowutgANxU0vIQybtQ6keFY
rSxrZ3n52OhkcnBtB7KTXNG1JDAGQa3YgCYPbsWmY0AvGwJuAmV6aouswO+2t50w
VMD8ts6AHad72FwcjI4/gNGTPdr6cKKTqsyXBZ0oZbY3711gYIRUdcgnWpaYMcqh
KUY4bsraC/+fghGG7s/Rj3rNgLO07ypdxHAlh1nl+ip8a9lNq3TKhYAGqjlbHYd1
OXbYVRUW60d+yJ1yL9qo6gSsG2GfUb1vSaEvoJiESbiKftvuMaGjHkjN9FZ139++
Cd90tk+2dD32zyYdGNUM/GmquNnFDMKrqcRLlgVoIfJ7IW1XP5Y=
=IA21
-----END PGP SIGNATURE-----
--=-=-=--