From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbdLGJUl (ORCPT ); Thu, 7 Dec 2017 04:20:41 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:35051 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbdLGJUh (ORCPT ); Thu, 7 Dec 2017 04:20:37 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20171207092034euoutp027f44d5b0e3532b7a57a4a6204e427a00~9_KRPj9O81213812138euoutp02v X-AuditID: cbfec7f1-f793a6d00000326b-68-5a2907e1e71c From: =?utf-8?Q?=C5=81ukasz_Stelmach?= To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, Stephan Mueller , Herbert Xu , "David S. Miller" , Kukjin Kim , linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , =?utf-8?Q?Bart=C5=82omiej_=C5=BBo?= =?utf-8?Q?=C5=82nierkiewicz?= Subject: Re: [PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs Date: Thu, 07 Dec 2017 10:20:27 +0100 In-reply-to: Message-id: <87y3me99no.fsf%l.stelmach@samsung.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-version: 1.0 Content-type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGKsWRmVeSWpSXmKPExsWy7djPc7oP2TWjDP6+5bfYOGM9q8Wc8y0s Ft2vZCz6H79mtjh/fgO7xf17P5ksLu+aw2Yx4/w+Jou1R+6yW7TuPcJuMfX0WhYHbo9PV64w eWxZeZPJY9sBVY9NqzrZPPq2rGL0+LxJLoAtissmJTUnsyy1SN8ugSvj2pOlrAV9EhVHdnxm a2B8KdzFyMkhIWAi0fJuKRuELSZx4d56IJuLQ0hgKaPEmW3zoZzPjBJbbx5lh+m4u6YPKrGM UaJj3lxWCOcLo8S8w/dYQKrYBOwl+o/sA7NFBDQlrv/9DlbELLCYWeLb0cVgC4UFnCT6Oi+C jWURUJVY/OAdI4jNKRAscXHyRLBmXgFjiY6GY8wgtqiApcS9vrtsEHFBiR+TIZYxC+RKfGr6 zw6yQEKgm11iycHXUB+5SLxZfYIVwhaWeHV8C9QPMhKdHQeZIBr6GSUOz/8OlZjCKLF4oQOE bS3xZ9VENogNfBKTtk0HuoIDKM4r0dEmBFHiITHpfRtUq6PE2SctzJCgWMIocWX1W6YJjLKz kBw7C8mxs4BGMQNDZv0ufYiwtsSyha+ZIWxbiXXr3rMsYGRdxSiSWlqcm55abKRXnJhbXJqX rpecn7uJEZiCTv87/nEH4/sTVocYBTgYlXh4K56rRwmxJpYVV+YeYlQBGvNow+oLjFIsefl5 qUoivL/7NaKEeFMSK6tSi/Lji0pzUosPMUpzsCiJ89pGtUUKCaQnlqRmp6YWpBbBZJk4OKUa GBk/Td6zjfXSzijdBpWnLzf5rnfsaF54/Hfix9aWaQWF8rFye6siV3z7uvxcCX/THOEdwVHG rrx/xJpDgz+rd557wvmV8fux9y3SN/1Dlp2R21fHNVXM5cz/vrk3Zzy4tMco78SRB+83xdUU WmWErZ3mME8zwMLotd0O3kKlpc3Xd6zT8H8h+0uJpTgj0VCLuag4EQB54eepSQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e/4Fd0H7JpRBlP+allsnLGe1WLO+RYW i+5XMhb9j18zW5w/v4Hd4v69n0wWl3fNYbOYcX4fk8XaI3fZLVr3HmG3mHp6LYsDt8enK1eY PLasvMnkse2AqsemVZ1sHn1bVjF6fN4kF8AWxWWTkpqTWZZapG+XwJVx7clS1oI+iYojOz6z NTC+FO5i5OSQEDCRuLumjw3CFpO4cG89kM3FISSwhFHi4qzjjBDON0aJW5N/soBUsQnYS/Qf 2QdmiwhoSlz/+50VpIhZYCmzxMcNt9lBEsICThJ9nRfBbCGBAIn9t7czgdgsAqoSix+8YwSx OQWCJdpnXwOzeQWMJToajjGD2KIClhL3+u6yQcQFJX5Mvge2jFkgW+LCxTcsExj5ZyFJzUKS msXIAWRrSqzfpQ8R1pZYtvA1M4RtK7Fu3XuWBYysqxhFUkuLc9Nziw31ihNzi0vz0vWS83M3 MQJjZduxn5t3MF7aGHyIUYCDUYmH98JL9Sgh1sSy4srcQ4wqQGMebVh9gVGKJS8/L1VJhPd3 v0aUEG9KYmVValF+fFFpTmrxIUZpDhYlcd7ePasjhQTSE0tSs1NTC1KLYLJMHJxSDYylm6f9 a/n6sjUgclvRsUlPXka7RJyyKd9sm7eZh1et8qJKTYql6ATr1rcLREUXMTyZm8Xw11dv3u16 7uUlazg69d70T2So2n8n4Npfj+3S96NS7x8X1/IRPjLl/bt3Z4P5eCbkVDg/S3pi/GLuEf5L GrHBE3be3vtPl13pycv6e4c3bz/y82emEktxRqKhFnNRcSIADVf5Ip0CAAA= X-CMS-MailID: 20171207092032eucas1p296f7cbc547d159c52561182cc6461504 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171207092032eucas1p296f7cbc547d159c52561182cc6461504 X-RootMTR: 20171207092032eucas1p296f7cbc547d159c52561182cc6461504 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It was <2017-12-06 =C5=9Bro 16:28>, when Krzysztof Kozlowski wrote: > On Wed, Dec 6, 2017 at 3:53 PM, =C5=81ukasz Stelmach wrote: >> It was <2017-12-06 =C5=9Bro 15:05>, when Krzysztof Kozlowski wrote: >>> On Wed, Dec 6, 2017 at 2:42 PM, =C5=81ukasz Stelmach wrote: >>>> It was <2017-12-05 wto 14:34>, when Krzysztof Kozlowski wrote: >>>>> On Tue, Dec 5, 2017 at 1:35 PM, =C5=81ukasz Stelmach wrote: >>>>>> Add support for PRNG in Exynos5250+ SoCs. >>>>>> >>>>>> Signed-off-by: =C5=81ukasz Stelmach >>>>>> --- [...] >>>>>> + dev_info(&pdev->dev, >>>>>> + "Exynos Pseudo Random Number Generator (typ= e:%d)\n", >>>>> >>>>> dev_dbg, this is not that important information to affect the boot ti= me. >>>> >>>> Quite many devices report their presence during boot with such >>>> messages. For example: >>>> >>>> [ 3.390247] exynos-ehci 12110000.usb: EHCI Host Controller >>>> [ 3.395493] exynos-ehci 12110000.usb: new USB bus registered, assig= ned bus number 1 >>>> [ 3.403702] exynos-ehci 12110000.usb: irq 80, io mem 0x12110000 >>>> [ 3.431793] exynos-ehci 12110000.usb: USB 2.0 started, EHCI 1.00 >>>> >>>> From my experience it isn't printk() itself that slows down boot but t= he >>>> serial console. >>> >>> True, the console is bottleneck (not necessarily serial) [1] but that >>> does not change the fact there is no need to print the type of RNG. >> >> With values of the enum not being meaningful themselves printing the >> type does not make much sense for me too. Is it ok just to print report >> the device presence? > > This does not change mine arguments - this printk does not bring any > information except that there is such device. Later you might want to > print this for Exynos TRNG. Later for other module, and other. Thus I > prefer not to add it. On the other hand that is not a reason to stop > this patch so for example you could split it into separate commit. Done. > It is kind of unrelated change and keeping it separate will not block > everything if maintainer will not want it. I will. As a user a prefer when devices report their presence in the log buffer and I will submit such patch. =2D-=20 =C5=81ukasz Stelmach Samsung R&D Institute Poland Samsung Electronics --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBCAAGBQJaKQfbAAoJELCuHpyYpYAQw3QH/1f5OLQe+NIv24w1/YJikhPX fpJM9LzXipNTD96cEa+yI9WSXsGIBo4d6iOuM3UGSCmgWIWG5vNap9BjB6fRD+vZ KYxfeAruW6UzglzjOEcDNlh5x2wIcmaPfDhUi4+rHreEZeqV7Ggl8VjLzEJJTieE tql9KI9z/iEZ4CYEqRGGsmjVJqnmZKd1OMXffdteEmI/GnNMja4jmq3uF3xiiIHT efpbwKyxZY6tOQOtqj2ehEHmJ01ex7YkxrLFfEOqWKEFHK/o+/3u9DmWLQVgBffw 1MgIK2ob+d0Pb019Sz4k1YPdAEoj0QAe7c6JpfNBjQc9w+3WXQsH0wgbL0EBLjA= =8qlz -----END PGP SIGNATURE----- --=-=-=--