From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932562AbdJYKah (ORCPT ); Wed, 25 Oct 2017 06:30:37 -0400 Received: from ozlabs.org ([103.22.144.67]:53935 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932401AbdJYKaf (ORCPT ); Wed, 25 Oct 2017 06:30:35 -0400 From: Michael Ellerman To: Paul Mackerras , Matthew Wilcox Cc: "linuxppc-dev\@ozlabs.org" , Linus Torvalds , linux-kernel@vger.kernel.org, "linux-s390\@vger.kernel.org" Subject: Re: [PATCH] bitmap: Fix optimization of bitmap_set/clear for big-endian machines In-Reply-To: <20171025084602.GC25140@fergus.ozlabs.ibm.com> References: <20171025065726.GA25140@fergus.ozlabs.ibm.com> <20171025084602.GC25140@fergus.ozlabs.ibm.com> Date: Wed, 25 Oct 2017 12:30:24 +0200 Message-ID: <87y3nzzfi7.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Mackerras writes: > On Wed, Oct 25, 2017 at 07:39:48AM +0000, Matthew Wilcox wrote: >> Hang on, don't tell me you found this by inspection. Are you not >> running the bitmap testcase, enabled by CONFIG_TEST_BITMAP? Either >> that should be producing an error, or there's a missing test case, or >> your inspection is wrong ... Oops. [ 1.907533] test_bitmap: test 13: input is '0-2047:128/256' OK, Time: 1359 [ 1.907596] set not equal 0 8 [ 1.907640] set not __equal 0 8 [ 1.907684] clear not equal 0 8 [ 1.907728] clear not __equal 0 8 [ 1.907772] set not equal 0 16 [ 1.907816] set not __equal 0 16 [ 1.907861] clear not equal 0 16 [ 1.907905] clear not __equal 0 16 [ 1.907949] set not equal 0 24 [ 1.907993] set not __equal 0 24 [ 1.908038] clear not equal 0 24 [ 1.908082] clear not __equal 0 24 ... [ snip ~30,000 lines ] ... [ 3.345729] set not equal 1008 8 [ 3.345773] set not __equal 1008 8 [ 3.345818] clear not equal 1008 8 [ 3.345863] clear not __equal 1008 8 [ 3.345909] test_bitmap: all 460506 tests passed ^^^^^^^^^^^^^^^^^^^^^^^ O_o With the patch: [ 1.904393] test_bitmap: test 13: input is '0-2047:128/256' OK, Time: 1359 [ 1.916270] test_bitmap: all 460506 tests passed cheers