From: Kalle Valo <kvalo@codeaurora.org>
To: "Reizer\, Eyal" <eyalr@ti.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
"\,Tony Lindgren" <tony@atomide.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Julian Calaby <julian.calaby@gmail.com>
Subject: Re: [v7 wlcore: add missing nvs file name info for wilink8
Date: Wed, 16 Aug 2017 16:57:45 +0300 [thread overview]
Message-ID: <87y3qj7gyu.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B36427AC2@DFRE01.ent.ti.com> (Eyal Reizer's message of "Wed, 16 Aug 2017 07:17:53 +0000")
"Reizer, Eyal" <eyalr@ti.com> writes:
>> > + if (wl->fuse_oui_addr == 0 && wl->fuse_nic_addr == 0) {
>> > + wl1271_warning("Fuse mac address is zero. using "
>> > + "random mac\n");
>>
>> This one should also go into one line.
>
> This will still exceed 80 characters. Is this still ok?
Yes, it's ok that the _format string_ goes above 80 chars, but if there
are paremeters you should split them to a separate line. Example:
pr_debug("This is an example of a very long message which also prints few variables foo %d bar %d",
foo, bar);
--
Kalle Valo
prev parent reply other threads:[~2017-08-16 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 12:15 Reizer, Eyal
2017-08-14 16:04 ` Tony Lindgren
2017-08-15 13:09 ` Sebastian Reichel
2017-08-16 7:17 ` Reizer, Eyal
2017-08-16 13:57 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3qj7gyu.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=eyalr@ti.com \
--cc=julian.calaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®