From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385AbdFMItF (ORCPT ); Tue, 13 Jun 2017 04:49:05 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:46866 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbdFMItD (ORCPT ); Tue, 13 Jun 2017 04:49:03 -0400 From: Gregory CLEMENT To: Ralph Sennhauser Cc: linux-arm-kernel@lists.infradead.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Genoud Subject: Re: [PATCH] ARM: dts: mvebu: Add PWM properties for armada-38x References: <20170601201030.22525-1-ralph.sennhauser@gmail.com> Date: Tue, 13 Jun 2017 10:48:50 +0200 In-Reply-To: <20170601201030.22525-1-ralph.sennhauser@gmail.com> (Ralph Sennhauser's message of "Thu, 1 Jun 2017 22:10:30 +0200") Message-ID: <87y3sw8e8d.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ralph, On jeu., juin 01 2017, Ralph Sennhauser wrote: > Add the required properties to the GPIO nodes for them to be used as PWM > lines. > > Signed-off-by: Ralph Sennhauser Applied on mvebu/dt Thanks, Gregory > > --- > > Hi everyone, > > this patch uses "marvell,armada-370-gpio" for the compatible property > and as such depends on the rename of the property to still make it in in > time for 4.12 ("gpio: mvebu: change compatible string for PWM support"). > Otherwise the compatible string will need to be amended to > "marvell,armada-370-xp-gpio". > > Checked the functional spec and the register ranges and offsets are the > same as for armada-xp. Likely the same holds true for the armada-39x > family, though I neither have access to the spec nor any such hardware. > > Ralph > --- > arch/arm/boot/dts/armada-38x.dtsi | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index 8b165c3..af31f5d 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -312,31 +312,39 @@ > }; > > gpio0: gpio@18100 { > - compatible = "marvell,orion-gpio"; > - reg = <0x18100 0x40>; > + compatible = "marvell,armada-370-gpio", > + "marvell,orion-gpio"; > + reg = <0x18100 0x40>, <0x181c0 0x08>; > + reg-names = "gpio", "pwm"; > ngpios = <32>; > gpio-controller; > #gpio-cells = <2>; > + #pwm-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > interrupts = , > , > , > ; > + clocks = <&coreclk 0>; > }; > > gpio1: gpio@18140 { > - compatible = "marvell,orion-gpio"; > - reg = <0x18140 0x40>; > + compatible = "marvell,armada-370-gpio", > + "marvell,orion-gpio"; > + reg = <0x18140 0x40>, <0x181c8 0x08>; > + reg-names = "gpio", "pwm"; > ngpios = <28>; > gpio-controller; > #gpio-cells = <2>; > + #pwm-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > interrupts = , > , > , > ; > + clocks = <&coreclk 0>; > }; > > systemc: system-controller@18200 { > -- > 2.10.2 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com