From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751321AbdFEFqT convert rfc822-to-8bit (ORCPT ); Mon, 5 Jun 2017 01:46:19 -0400 Received: from ozlabs.org ([103.22.144.67]:38957 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbdFEFqR (ORCPT ); Mon, 5 Jun 2017 01:46:17 -0400 From: Michael Ellerman To: Balbir Singh , Christophe LEROY Cc: kbuild test robot , linux-pm@vger.kernel.org, "open list\:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)" , "linux-kernel\@vger.kernel.org" , Paul Mackerras , kbuild-all@01.org, "Naveen N. Rao" , Laura Abbott , Linus Torvalds , Rashmica Gupta Subject: Re: [PATCH v1 7/8] powerpc/Kconfig: Enable STRICT_KERNEL_RWX In-Reply-To: References: <201705260000.CDMt1Ieh%fengguang.wu@intel.com> <6dcd8ea3-e953-3319-0e0e-8543018e882f@c-s.fr> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 05 Jun 2017 15:46:13 +1000 Message-ID: <87y3t7q95m.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Balbir Singh writes: > On Mon, May 29, 2017 at 6:00 PM, Christophe LEROY > wrote: >> Le 25/05/2017 à 18:45, kbuild test robot a écrit : >>> All errors (new ones prefixed by >>): >>> >>>>> kernel//power/snapshot.c:40:28: fatal error: asm/set_memory.h: No such >>>>> file or directory >>> >>> #include >> >> >> Looks like it is linked to commit 50327ddfb ("kernel/power/snapshot.c: use >> set_memory.h header"). >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=50327ddfb >> >> I believe that inclusion should be conditional to >> CONFIG_ARCH_HAS_SET_MEMORY, which is not set by powerpc arch, just like in >> include/linux/filter.c >> > Agreed, it needs to be fixed in kernel/power/sanpshot.c It should be fixed in asm-generic/set_memory.h, there should be no need to guard an include of a generic header. cheers