From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030218AbdCXUMS (ORCPT ); Fri, 24 Mar 2017 16:12:18 -0400 Received: from turtle.smart-cactus.org ([163.172.166.228]:38144 "EHLO mail.smart-cactus.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965487AbdCXUMK (ORCPT ); Fri, 24 Mar 2017 16:12:10 -0400 X-Greylist: delayed 593 seconds by postgrey-1.27 at vger.kernel.org; Fri, 24 Mar 2017 16:12:09 EDT From: Ben Gamari To: Greg Kroah-Hartman , Yves-Alexis Perez Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Luis R. Rodriguez" , Ming Lei , Bjorn Andersson Subject: Re: [PATCH 4.8 50/96] firmware: fix usermode helper fallback loading In-Reply-To: <20170113105848.GA14806@kroah.com> References: <20170106214227.601120243@linuxfoundation.org> <20170106214229.739771341@linuxfoundation.org> <1483739678.4969.7.camel@corsac.net> <20170113105848.GA14806@kroah.com> Date: Fri, 24 Mar 2017 16:01:58 -0400 Message-ID: <87y3vue955.fsf@ben-laptop.smart-cactus.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Greg Kroah-Hartman writes: > On Fri, Jan 06, 2017 at 10:54:38PM +0100, Yves-Alexis Perez wrote: >> On Fri, 2017-01-06 at 22:43 +0100, Greg Kroah-Hartman wrote: >> > 4.8-stable review patch.=C2=A0=C2=A0If anyone has any objections, plea= se let me know. >>=20 >> Hi Greg, >>=20 >> Ben Gamari think there was a regression in that patch so I'm adding him = to >> recipients so he can voice concerns if needed. > > Given the lack of response, I'm going to assume all is fine :) > Oh dear, sorry for the late response; this was stuck in the pergatory of my inbox. It's been a while since I've looked at this, but I believe the alleged regression in this pastch is the reason I have the attached patch in my tree. I seem to recall that it was the ath10k driver which triggered the issue. Unfortunately I can't recall which driver was affected by this. I'll have to see what happens when I revert the attached patch. Cheers, =2D Ben Author: Ben Gamari Date: Mon Jan 2 00:38:05 2017 -0500 firmware_class: Ensure buf is non-NULL in __fw_load_abort =20=20=20=20 I have observed that this can be NULL. diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index ac350c518e0c..fd0be24911fc 100644 =2D-- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -546,7 +546,8 @@ static void __fw_load_abort(struct firmware_buf *buf) * There is a small window in which user can write to 'loading' * between loading done and disappearance of 'loading' */ =2D if (fw_state_is_done(&buf->fw_st)) + + if (!buf || fw_state_is_done(&buf->fw_st)) return; =20 list_del_init(&buf->pending_list); --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEmwpsh4C13+CdDZRjcVB86Evun78FAljVezYACgkQcVB86Evu n7/IHAf+OUBkcokDXmRYXE7uzXuHSwR9mNYa1vkX1oCPpmjFd2PCJFlwWDLa8GyS afHwPO3vXX/5xXG9AZXopPVkMOjaRxs7+m4lWpslozozssSWxgkEaXTuTcdxWIfS Y6/rV3Gg1r0ImRH6qRV7D4bW1oLppuCb6+8XPrsUDVV3PlFZrxM2YSQkFpoZDaQV ofrnB/Wb6+mIV7/uiusfi2FJRfnCvTqZM5zssboUJoJBx/kGFpyEZ0HiWH673Qzu IZ0xlJkFI/1fUtRoTlsEFd4+SL5IHFpCw1LGUGkOqDbtq0eR439+o5U/JD45ibx7 D7GBiwbCnRNqaofnlWFpooaAaJHxGA== =bH5s -----END PGP SIGNATURE----- --=-=-=--