From: Chris Brannon <chris@the-brannons.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kirk Reiser <kirk@reisers.ca>,
William Hubbs <w.d.hubbs@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
speakup@linux-speakup.org
Subject: Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters
Date: Fri, 03 Mar 2017 10:39:30 -0800 [thread overview]
Message-ID: <87y3wmjjbx.fsf@the-brannons.com> (raw)
In-Reply-To: <20170302015353.541599561@ens-lyon.org> (Samuel Thibault's message of "Thu, 02 Mar 2017 02:53:54 +0100")
Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
> This extends the synth buffer slots to 16bit, so as to hold 16bit
> unicode characters.
>
> synth_buffer_getc and synth_buffer_peek now return 16bit characters.
> Speech synthesizers which do not support characters beyond latin1 can
> use the synth_buffer_skip_nonlatin1() helper to skip the non-latin1
> characters before getting or peeking. All synthesizers are made to use
> it for now.
>
> This makes synth_buffer_add take a 16bit character. For simplicity for
> now, synth_printf is left to using latin1 formats and strings.
> synth_putwc, synth_putwc_s, synth_putws and synth_putws_s helpers are
> however added to put 16bit characters and strings.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Chris Brannon <chris@the-brannons.com>
Looks good to me.
next prev parent reply other threads:[~2017-03-03 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 1:53 [patch 0/3] speakup: support 16bit unicode screen reading Samuel Thibault
2017-03-02 1:53 ` [patch 1/3] speakup: extend synth buffer to 16bit unicode characters Samuel Thibault
2017-03-03 18:39 ` Chris Brannon [this message]
2017-03-02 1:53 ` [patch 2/3] speakup: convert screen reading to 16bit characters Samuel Thibault
2017-03-04 8:50 ` Okash Khawaja
2017-03-04 8:59 ` Okash Khawaja
2017-03-02 1:53 ` [patch 3/3] speakup: add unicode variant of /dev/softsynth Samuel Thibault
2017-03-03 18:40 ` Chris Brannon
2017-03-04 14:01 [patch 0/3] speakup: support 16bit unicode screen reading Samuel Thibault
2017-03-04 14:01 ` [patch 1/3] speakup: extend synth buffer to 16bit unicode characters Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3wmjjbx.fsf@the-brannons.com \
--to=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®