From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbcDVIt3 (ORCPT ); Fri, 22 Apr 2016 04:49:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36349 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbcDVIt1 (ORCPT ); Fri, 22 Apr 2016 04:49:27 -0400 From: Vitaly Kuznetsov To: Haiyang Zhang Cc: davem@davemloft.net, netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Subject: Re: [PATCH net-next] hv_netvsc: Fix the list processing for network change event References: <1461280381-17530-1-git-send-email-haiyangz@microsoft.com> Date: Fri, 22 Apr 2016 10:49:19 +0200 In-Reply-To: <1461280381-17530-1-git-send-email-haiyangz@microsoft.com> (Haiyang Zhang's message of "Thu, 21 Apr 2016 16:13:01 -0700") Message-ID: <87y486yqnk.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Haiyang Zhang writes: > RNDIS_STATUS_NETWORK_CHANGE event is handled as two "half events" -- > media disconnect & connect. The second half should be added to the list > head, not to the tail. So all events are processed in normal order. > Thanks, this matters when we get some other events in between these two halves. Reviewed-by: Vitaly Kuznetsov > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan > --- > drivers/net/hyperv/netvsc_drv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c > index bfdb568a..ba3f3f3 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -1125,7 +1125,7 @@ static void netvsc_link_change(struct work_struct *w) > netif_tx_stop_all_queues(net); > event->event = RNDIS_STATUS_MEDIA_CONNECT; > spin_lock_irqsave(&ndev_ctx->lock, flags); > - list_add_tail(&event->list, &ndev_ctx->reconfig_events); > + list_add(&event->list, &ndev_ctx->reconfig_events); > spin_unlock_irqrestore(&ndev_ctx->lock, flags); > reschedule = true; > } -- Vitaly