mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fat: add config option to set UTF-8 mount option by default
Date: Tue, 08 Mar 2016 15:21:21 +0900	[thread overview]
Message-ID: <87y49t4hi6.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <56DB58FB.9080504@maciej.szmigiero.name> (Maciej S. Szmigiero's message of "Sat, 05 Mar 2016 23:08:59 +0100")

"Maciej S. Szmigiero" <mail@maciej.szmigiero.name> writes:

> +#ifdef CONFIG_FAT_DEFAULT_UTF8
> +	opts->utf8 = is_vfat;
> +#else
> +	opts->utf8 = 0;
> +#endif
> +

Maybe, better to use IS_ENABLED(CONFIG_FAT_DEFAULT_UTF8)?

I.e.,

	opts->utf8 = IS_ENABLED(CONFIG_FAT_DEFAULT_UTF8) && is_vfat;

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

      reply	other threads:[~2016-03-08  6:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-05 22:08 Maciej S. Szmigiero
2016-03-08  6:21 ` OGAWA Hirofumi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y49t4hi6.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®