From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755129AbcBWUMj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Feb 2016 15:12:39 -0500
Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:45837 "EHLO
	smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753051AbcBWUMi convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Feb 2016 15:12:38 -0500
X-ME-Helo: belgarion
X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy
X-ME-Date: Tue, 23 Feb 2016 21:12:34 +0100
X-ME-IP: 109.220.219.11
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sergei Ianovich <ynvich@gmail.com>
Cc: linux-kernel@vger.kernel.org, Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        "moderated list\:PXA2xx\/PXA3xx SUPPORT" 
	<linux-arm-kernel@lists.infradead.org>,
        "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb
References: <1456139297-5854-1-git-send-email-ynvich@gmail.com>
	<87oab8wyfe.fsf@belgarion.home> <1456228901.23036.9.camel@gmail.com>
X-URL: http://belgarath.falguerolles.org/
Date: Tue, 23 Feb 2016 21:12:25 +0100
In-Reply-To: <1456228901.23036.9.camel@gmail.com> (Sergei Ianovich's message
	of "Tue, 23 Feb 2016 15:01:41 +0300")
Message-ID: <87y4abuqxi.fsf@belgarion.home>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sergei Ianovich <ynvich@gmail.com> writes:

> Hi Robert, 
>
> On Mon, 2016-02-22 at 16:35 +0100, Robert Jarzmik wrote:
>> You're right, I haven't seen the pxa2xx.dtsi statement before.
>> 
>> As such, could you amend a bit your patch please to :
>>  - add:
>> Fixes: 0ec1939668e5 ("ARM: dts: pxa: add the usb host controller")
>>  - make the same change in pxa3xx.dtsi, as the same error is there
>>  - and more globally align pxa2xx.dtsi, pxa27x.dtsi and pxa3xx.dtsi
>>  - remove the compatible, reg, interrupts and status from both pxa27x.dtsi and
>>    pxa3xx.dtsi as they are redundant with the included pxa2xxx.dsti one
>
> No problem. Let's figure out the best approach.
>
>> I'm even wondering if the proper change wouldn't be to scrap the ohci
>> declarations from pxa27x.dtsi and pxa3xx.dtsi, and only add the "clocks"
>> property to pxa2xx.dtsi ...
>
> Since clocks are declared in pxa27x.dtsi and pxa3xx.dtsi, there is a
> stronger ground to have node clocks properties set in pxa27x.dtsi
> and pxa3xx.dtsi as well. However, there is already nodes with clocks
> properties in pxa2xx.dtsi.
>
> I cannot choose, you should make a decision.
I have checked my manuals, and pxa25x doesn't have an USB Host controller.

So I'd rather have :
 - remove the usb0: ohci@4c000000 node from pxa2xx.dtsi
 - add it completely to pxa27x.dtsi and pxa3xx.dtsi, with clocks and everything,
   in "disabled" status.

Cheers.

-- 
Robert