From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [PATCH] ARM: pxa: cm-x2xx: avoid duplicate macro warnings
Date: Wed, 09 Dec 2015 22:00:49 +0100 [thread overview]
Message-ID: <87y4d3jq0u.fsf@belgarion.home> (raw)
In-Reply-To: <5126103.CuC5iMSqYG@wuerfel> (Arnd Bergmann's message of "Wed, 09 Dec 2015 17:52:06 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> In an old commit, we worked around the duplicate definition of
> GPIO24_SSP1_SFRM in cm-x2xx.c, which includes files for both
> pxa25x and pxa27x. Apparently the problem has come back and we
> now have four additional duplicate symbols that cause warnings:
>
> In file included from /git/arm-soc/arch/arm/mach-pxa/pxa27x.h:7:0,
> from /git/arm-soc/arch/arm/mach-pxa/cm-x2xx.c:27:
> /git/arm-soc/arch/arm/mach-pxa/mfp-pxa27x.h:21:0: warning: "GPIO86_GPIO" redefined
> #define GPIO86_GPIO MFP_CFG_IN(GPIO86, AF0)
>
> This uses the same hack as before and undefines all symbols that
> are defined more than once. Fortunately, cm-x2xx does not need
> any of these.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Digging out old patches of 2012, cool.
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
I suppose it's a necessary hack until I manage to kill the mfp interface in
favor of pinctrl.
Cheers.
--
Robert
prev parent reply other threads:[~2015-12-09 21:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 16:52 Arnd Bergmann
2015-12-09 21:00 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4d3jq0u.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=arnd@arndb.de \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®