From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933940AbbKSKFw (ORCPT ); Thu, 19 Nov 2015 05:05:52 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:36262 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755273AbbKSKFs (ORCPT ); Thu, 19 Nov 2015 05:05:48 -0500 From: Rasmus Villemoes To: Andy Shevchenko Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/7] test_hexdump: introduce test_hexdump_prepare_test() helper Organization: D03 References: <1447259718-19647-1-git-send-email-andriy.shevchenko@linux.intel.com> <1447259718-19647-3-git-send-email-andriy.shevchenko@linux.intel.com> X-Hashcash: 1:20:151119:akpm@linux-foundation.org::WmI71Tdx3dBl35ct:0000000000000000000000000000000000000UK3 X-Hashcash: 1:20:151119:linux-kernel@vger.kernel.org::FE+SAH9Mkukyc27O:0000000000000000000000000000000003k3M X-Hashcash: 1:20:151119:andriy.shevchenko@linux.intel.com::ZHQ4hwBVoHzR9cC1:00000000000000000000000000008WS6 Date: Thu, 19 Nov 2015 11:05:45 +0100 In-Reply-To: <1447259718-19647-3-git-send-email-andriy.shevchenko@linux.intel.com> (Andy Shevchenko's message of "Wed, 11 Nov 2015 18:35:13 +0200") Message-ID: <87y4dus3ra.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11 2015, Andy Shevchenko wrote: > The function prepares the expected result in the provided buffer. > > Signed-off-by: Andy Shevchenko > --- > lib/test_hexdump.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) Makes sense. It does improve readability slightly. Acked-by: Rasmus Villemoes